Bug 84211 - [Markers] Make use of the new DeferredContentProvider in the problems view
Summary: [Markers] Make use of the new DeferredContentProvider in the problems view
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2005-02-02 02:18 EST by Stefan Xenos CLA
Modified: 2006-04-07 12:48 EDT (History)
4 users (show)

See Also:


Attachments
Start of a fix (143.78 KB, patch)
2005-02-02 02:20 EST, Stefan Xenos CLA
no flags Details | Diff
Zipped version of these classes (45.68 KB, application/octet-stream)
2005-10-12 15:25 EDT, Tod Creasey CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Xenos CLA 2005-02-02 02:18:10 EST
See bug 60117
Comment 1 Stefan Xenos CLA 2005-02-02 02:20:42 EST
Created attachment 17620 [details]
Start of a fix

Not finished yet. Attaching this patch here so it doesn't get lost.
Comment 2 Stefan Xenos CLA 2005-02-02 02:31:32 EST
This will also fix bug 58836
Comment 3 Stefan Xenos CLA 2005-04-01 19:27:23 EST
See bug 65490
Comment 4 Stefan Xenos CLA 2005-04-05 15:45:52 EDT
This patch should be part of the M7 performance work. It will affect performance
in the following ways:

1. Reduce the number of jobs required to populate the marker views. The current
code requires 2 jobs per view. In its current form, the patch uses 1 job per
view plus 1 global search job.

2. Reduce memory overhead. Since all marker views would share the same model,
the cached form of any marker that appears in more than one marker view would
only be stored once. This would have a minor effect on a single workbench window
(since markers rarely show up in, say, both the problems and tasks view), but
would have big improvements for multiple workbench windows (especially with
respect to the number of allocated coallator keys).

3. Greatly improve the perceived performance of the marker views. Since the view
can respond to marker deltas, it can display markers as soon as they're
available rather than waiting until the build completes. It is hard to measure
this performance improvement exactly (since it depends entirely on the duration
of the build and when the builder fires off deltas), but it is likely to
improved perceived performance by an order of magnitude.
Comment 5 Michael Van Meekeren CLA 2005-04-06 11:56:25 EDT
Just to be thorough, we need to be very clear in describing what we are fixing
and why in performance areas like this and will require real tests that prove that:
A) we've gotten faster and/or smaller 
B) that percieved performance increases do not increase memory usage etc...
C) they were worth doing and we can show this
Comment 6 Stefan Xenos CLA 2005-07-06 18:53:29 EDT
Tod: this is the patch we were talking about. I was wondering if you could help
me to finish it.
Comment 7 Tod Creasey CLA 2005-10-12 15:25:07 EDT
Created attachment 28205 [details]
Zipped version of these classes

As this is getting more and more divergent I exported the classes with Stefans
changes to this zip
Comment 8 Tod Creasey CLA 2006-04-07 12:48:47 EDT
The rework in 3.2 was such that this is no longer relevant.