Community
Participate
Working Groups
eclipse-SDK-I20040427-win32.zip 1. Perform a search & display the results with the flat layout 2. Now sort the results by 'Parent Name'... notice the type names do not come first 2. Switch to the hierarchical layout, then back to the flat - now the type names are first
Didn't notice that its doing in the background. There is no visual clue that its resorting. Try to search for the constructor in org.eclipse.swt.widgets.Text
Thomas, can you comment on this.
We shouldn't be sorting in the background.
Is this related to the label provider bug for flat view ?
No, this is java search, the other was file search specific.
The UI update job must have been not quite done yet. I changed the update strategy to be more synchronous. The whole thing still takes forever for large result sets (for example, turning on decorators). There is nothing I can do until we have a scalable table viewer. In the mean time, use the tree view. Moving to platform-ui.
Renaming the PR. The ProblemsView implements something like this an we could push it up but it is too late in the 3.0 cycle for us to be able to do it now. We will have to do it for 3.1.
Reopening now that 3.0 has shipped
See bug 72358... it includes a generalized improvement on the current problem view sorter which could be used for TableViewer.
Created attachment 15188 [details] Stefans patch for the IDE
Created attachment 15189 [details] Stefans patch for JFace
Created attachment 15190 [details] Stefans new test suites
Created attachment 15191 [details] Tods updated TableViewer and changes to the Test Suites
I have moved the patches from Bug 72358 here as they are more relevant to this report
Note that there are two problems being looks at 1) Something that sorts and filters data in the background (Stefans work here) 2) Something that looks up elements lazily (see Bug 82240). If you are interested in the second issue please add yourself to the cc list or Bug 82240
Created attachment 17580 [details] Updated JFace patch. Integrated with TableViewer now. Here's an updated patch. Background filtering is now in, and TableViewer has been updated to work with the deferred content provider. One weekend well wasted. :-) Tod: I had make quite a few changes to TableViewer (I fixed some bugs and refactored to use Veronika's technique of re-clearing tableitems that can't be filled in rather than relying on the scroll listener)... This changes the ILazyContentProvider protocol, so you'll want to check this out. There's still some bugs I haven't squished yet. The LazySortedCollection is occasionally returning its lazy removal flag as though it was part of the collection, and TableViewer sometimes ends up with blank rows when scrolling in a very large table with pageup/pagedown.
Created attachment 17581 [details] Updates the marker views to use the DeferredContentProvider (NOT FINISHED -- FOR PERFORMANCE TESTING ONLY) This updates the problems view to use DeferredContentProvider. Definitely not for HEAD yet (some features are disabled and there's a compile error in one of the Task view actions)... but it's working well enough to test the JFace patch.
Created attachment 17582 [details] Updated test suites
DeferredContentProvider has been checked into HEAD. Filed bug 84210 for the original problem with the search view. Filed bug 84211 for the changes to the problems view. Fixed in HEAD.
verified in I20050215-2300
