Bug 7122 - Action Cleanup/Dispose
Summary: Action Cleanup/Dispose
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 7235
Blocks:
  Show dependency tree
 
Reported: 2001-12-19 23:49 EST by Darin Swanson CLA
Modified: 2009-08-30 02:20 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2001-12-19 23:49:26 EST
It would nice to have a package that was strictly for actions...just like jdt 
debug ui.  org.eclipse.debug.iternal.ui.actions
Comment 1 Darin Wright CLA 2001-12-31 11:16:59 EST
Agreed. There should be an action package. 

Where possible, actions should be contributed via plug-in XML rather than 
hardcoded by a view. Also, action updating (enabling) should be handled by the 
action rather than the view where possible. This reduces the cohesion between 
actions and views, and makes the actions more portable/reuseable.

Not sure if a bug has been filed against the workbench, but it is crucial 
that "view action delegates" get a "dispose" callback such that they can remove 
themselves as event listeners, etc. This is one roadblock I have found in using 
action contributions effectively.
Comment 2 Darin Swanson CLA 2001-12-31 12:51:09 EST
A dispose callback would work for bug 7010 as well...the reason I wanted to 
know when the last editor was closed was to remove the action delegate as a 
listener.
Comment 3 Nick Edgar CLA 2002-01-03 10:26:37 EST
Filed bug 7235 for the dispose problem.
Comment 4 Darin Swanson CLA 2002-02-09 17:14:11 EST
The current workaround for not having a dispose call on an IViewActionDelegate 
is to add the action as a IPartListener. When the part closes, this is treated 
as a dispose.
Comment 5 Darin Wright CLA 2002-05-14 10:39:47 EDT
Deferred until 7235 is fixed.
Comment 6 Darin Swanson CLA 2002-06-26 11:16:52 EDT
Resolving to later.
Comment 7 Darin Swanson CLA 2003-04-01 17:01:42 EST
We are using the IActionDelegate2 interface and the #dispose method this 
provides.

Closing.
Comment 8 Denis Roy CLA 2009-08-30 02:20:50 EDT
As of now 'LATER' and 'REMIND' resolutions are no longer supported.
Please reopen this bug if it is still valid for you.