Bug 7010 - [Contributions] IEditorActionDelegate needs setActiveEditor called when only editor closes
Summary: [Contributions] IEditorActionDelegate needs setActiveEditor called when only ...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC other
: P3 normal (vote)
Target Milestone: 2.1 M4   Edit
Assignee: Simon Arsenault CLA
QA Contact:
URL:
Whiteboard:
Keywords: api, investigate
Depends on:
Blocks: 7012
  Show dependency tree
 
Reported: 2001-12-17 13:27 EST by Darin Swanson CLA
Modified: 2002-12-02 14:58 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2001-12-17 13:27:31 EST
On 1211

I was expecting my IEditorActionDelegate action (AddBreakpointAction) to have 
setActiveEditor called when the only active editor is closed (setting the 
active editor to null).  This does not happen.
Comment 1 Unknown User CLA 2001-12-20 10:02:29 EST
This is currently not part of the editor action delegate lifecycle.  It is not 
appropriate to pass null through setActiveEditor now, because that would widen 
the interface.  I suggest a new interface is added to clarify the desire to 
receive better notification.
Comment 2 Darin Swanson CLA 2001-12-20 10:56:37 EST
I am confused...null is passed to this method all the time...when the delegate 
is initially created. If setActiveEditor can be called with null during the 
initDelegate part of the lifecycle why can it not be called when the only 
active editor is closed?  Likely what is really missing is a defined set of 
lifecycle methods for IEditorActionDelegate (init, dispose) so that we would 
not have to rely on setActiveEditor to play so many roles?
Comment 3 Unknown User CLA 2001-12-20 11:16:24 EST
In that case, it might be a worthwhile change.  Will consider more ..
Comment 4 Simon Arsenault CLA 2002-12-02 14:57:55 EST
Added IActionDelegate2 which provides the lifecycle methods for action 
delegates. It also replaces IActionDelegateWithEvent interface which now is 
marked as deprecated. Will be in 20021203 integration build.
Comment 5 Simon Arsenault CLA 2002-12-02 14:58:15 EST
Forgot to mark it as FIXED.