Bug 68445 - [Presentations] (regression) PartStack is making assumptions that the StackPresentation cookie type is an Integer
Summary: [Presentations] (regression) PartStack is making assumptions that the StackPr...
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-23 22:14 EDT by Stefan Xenos CLA
Modified: 2019-09-06 16:08 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Xenos CLA 2004-06-23 22:14:53 EDT 
The fix for bug 65835 added code that passes an Integer into
StackPresentation.add. This code works for DefaultStackPresentation, but will
cause a ClassCastException for a presentation that uses a different cookie type
(for example, an MDI-style presentation would be likely to use Points or
Rectangles). The second argument to addPart may only be an object that the
StackPresentation itself returned in a StackDropResult or null.

The workbench indicates the order of views in the perspective by the order of
calls to addPart. If DefaultPartPresentation chooses not to honor that order,
this is either a bug in DefaultPartPresentation or an intentional design
decision. However, it is not the responsibility of the workbench to work around
bugs in particular presentations.
Comment 1 Stefan Xenos CLA 2004-06-23 22:23:58 EDT 
Note that this breaks bug 65835. The workbench is now overriding the tab order
by making assumptions about the way DefaultStackPresentation interprets
drag/drop cookies.
Comment 2 Stefan Xenos CLA 2004-06-24 13:25:07 EDT 
Correction to comment 1: this breaks bug 62038, not bug 65835.
Comment 3 Michael Van Meekeren CLA 2004-07-21 15:18:25 EDT 
stefan, do you think this is critical for 3.0.1?  do you have a fix for this?
Comment 4 Stefan Xenos CLA 2004-07-22 18:53:08 EDT 
I shouldn't have flagged as major: presentations can workaround this by checking
if cookie instanceof Integer at the start of their add method.
Comment 5 Douglas Pollock CLA 2005-10-06 13:51:17 EDT 
Reassigning the last of Stefan's bugs.
Comment 6 Tod Creasey CLA 2006-04-12 21:58:34 EDT 
Paul is this obsolete?
Comment 7 Paul Webster CLA 2006-09-28 15:13:44 EDT 
Is this still a problem in 3.3?

PW
Comment 8 Denis Roy CLA 2007-06-22 09:32:40 EDT 
Changes requested on bug 193523
Comment 9 Eclipse Webmaster CLA 2019-09-06 16:08:00 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.