Community
Participate
Working Groups
build I20040604-0800 - new window in Java perspective - in the left view stack, the order is: Hierarchy, Package Explorer - it should be: Package Explorer, Hierarchy - in the bottom right view stack, the order is: Javadoc, Declaration, Problems - it should be: Problems, Javadoc, Declaration - see JavaPerspectiveFactory for the correct order Note that the resulting order is not the reverse of the correct order. It's as if what should be the first view in the folder is getting warped to the end.
Michael, please consider for RC2.
It's important for the initial layout to honour the order of views specified by the perspective factory.
Kim, this is likely similar to the saveState restoreState code for Editors, can you investigate?
The problem here is quite different. The problem is with our insertion logic in DefaultPartPresentation. We iterate through existing tabs asking if it's not visible and if its bounds are greater than 0. This works fine when the tab folder is actually visible, but breaks down when opening a perspective because the tab folder has not been sized and no tabs are visible. As a result, we keep pumping them into the beginning of the stack. And then there is the placeholder problem. We're ignoring the position of placeholders when views are created. We get the folder right, but not the position.
Fix in HEAD.
Verified in HEAD. There is one deviation from the old behaviour, however. If the folder being restored contains placeholders and one of them is realized, the order may not be as expected because of our code that shuffles tabs around based on the LRU queue.
This does not work on Linux. We have bounds checking logic that fails on linux because the bound with is never 0 - it's 1.
Edited fix in HEAD.
Verified on I200406181804.
Marking as such.
Closing to keep a tidy house. Pardon the spam.
