Bug 59289 - [launching] external tool builder names must be globally unique?
Summary: [launching] external tool builder names must be globally unique?
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.0   Edit
Hardware: PC Linux-GTK
: P3 enhancement with 3 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 103029 107274 130204 135258 154774 163303 165151 365232 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-04-20 12:17 EDT by Adam Kiezun CLA
Modified: 2015-09-23 06:17 EDT (History)
15 users (show)

See Also:


Attachments
patch (7.94 KB, patch)
2006-11-30 12:37 EST, Darin Wright CLA
no flags Details | Diff
testprojects (2.15 KB, application/zip)
2015-09-22 09:15 EDT, Martin Oberhuber CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2004-04-20 12:17:13 EDT
3.0 M7

it seems that external tool builder names must be globally unique
i wanted to have 2 external tool builders for /usr/bin/make for 2 different
projects, both called 'make clean' - eclipse would not allow me

this restriction seems unnecessary
Comment 1 Darin Wright CLA 2004-04-20 15:48:35 EDT
This is an artificial limitation in the launch framework, imposed by the 
launch dialog. The only real limitation is that two configs in the same 
directory/folder (metadata) cannot have the same name (since the name is used 
as the file name).

We should be able to relax this.
Comment 2 Jared Burns CLA 2004-05-07 19:58:11 EDT
If a configuration isn't shared, the name has to be unique because we store the configs in files in the 
same location (the metadata area).

For shared configs, we can get more complex. So long as the file location isn't the same, the names 
can be the same. But we need to make sure that when the user changes a shared config's location 
that we re-verify that there's no name collision.
Comment 3 Adam Kiezun CLA 2004-05-07 20:09:18 EDT
>If a configuration isn't shared, the name has to be unique because we store the
>configs in files in the same location (the metadata area).

sounds like an implementation detail that surfaces as nuisance for users
Comment 4 Darin Wright CLA 2004-05-12 16:55:44 EDT
Deferred, post 3.0. Too late for this change. As well, it creates problems in 
the LCD when configs have the same name (i.e. the tree needs to render more 
info to be able to distinguish them). 
Comment 5 Darin Wright CLA 2004-08-03 14:18:50 EDT
Consider for 3.1
Comment 6 Darin Wright CLA 2004-12-13 10:14:07 EST
Deferred
Comment 7 Darin Swanson CLA 2005-07-07 12:39:20 EDT
*** Bug 103029 has been marked as a duplicate of this bug. ***
Comment 8 Darin Swanson CLA 2005-08-17 18:40:46 EDT
*** Bug 107274 has been marked as a duplicate of this bug. ***
Comment 9 Darin Swanson CLA 2006-03-06 01:27:07 EST
*** Bug 130204 has been marked as a duplicate of this bug. ***
Comment 10 Darin Wright CLA 2006-04-06 10:41:20 EDT
*** Bug 135258 has been marked as a duplicate of this bug. ***
Comment 11 Darin Wright CLA 2006-04-28 10:59:55 EDT
*** Bug 135258 has been marked as a duplicate of this bug. ***
Comment 12 Darin Swanson CLA 2006-08-23 14:02:58 EDT
*** Bug 154774 has been marked as a duplicate of this bug. ***
Comment 13 Darin Wright CLA 2006-11-06 10:14:13 EST
*** Bug 163303 has been marked as a duplicate of this bug. ***
Comment 14 Darin Wright CLA 2006-11-20 09:57:26 EST
*** Bug 165151 has been marked as a duplicate of this bug. ***
Comment 15 Darin Wright CLA 2006-11-30 12:37:43 EST
Created attachment 54801 [details]
patch

This is a work in progress that allows configs to have the same name if stored in different locations. It enhances the way "local" configs are stored. Rather than storing them all in one directory in the metadata, a directory structure is created based on the resource that a configruation is stored with. It effectively gives configurations a namespace based on their resource mapping. So, two configs can have the same name if the're not associated with the same "container" resource.

It does not add UI support to distingusish between configs with the same name.
Comment 16 Alexei Alexandrov CLA 2006-12-01 01:51:18 EST
What if launch configuration is not associated with any resource? Or what if it's associated with multiple resources?

P.S. Sorry, I didn't have time to look at the patch itself.
Comment 17 Darin Wright CLA 2006-12-01 09:04:13 EST
No resource == default package (i.e. all configs that have no resource association share the same namespace).

Multiple resoruces == use the first resource (not sure what the rule should be here - probably should use the "deepest" resource in the association, but if it's cross project resources, then not sure what to do).
Comment 18 Denis Roy CLA 2009-08-30 02:20:40 EDT
As of now 'LATER' and 'REMIND' resolutions are no longer supported.
Please reopen this bug if it is still valid for you.
Comment 19 Michael Rennie CLA 2011-11-30 16:23:13 EST
*** Bug 365232 has been marked as a duplicate of this bug. ***
Comment 20 Holger Machens CLA 2013-02-06 10:56:39 EST
As requested by Denis Roy (see comment above), I would like to have this bug reopened, because it seems as if the patch has never been applied or is not functioning.

The issue still exists in 
  Version: Indigo Service Release 1
  Build id: 20110916-0149

Because this is an enhancement request, I would like to suggest an related enhancement which allows the use of a global external tool launcher by a logical reference (no file system soft link) instead of copying it to the project folder. (It could be another option besides creating a new builder or importing a global one). 
I think this is the actual reason why most people would like to have the same name for a builder in multiple projects. It would even allow to migrate the same project on different platforms without changing the external tool builder launcher each time you switch between them (consider for example different OSs or different tools doing the same thing). This would come in very handy e.g. for teams working on a common source code repository which contains the project configuration as well.
Comment 21 Michael Rennie CLA 2013-02-06 11:10:23 EST
(In reply to comment #20)

> Because this is an enhancement request, I would like to suggest an related
> enhancement which allows the use of a global external tool launcher by a
> logical reference (no file system soft link) instead of copying it to the
> project folder. (It could be another option besides creating a new builder
> or importing a global one). 
> I think this is the actual reason why most people would like to have the
> same name for a builder in multiple projects. It would even allow to migrate
> the same project on different platforms without changing the external tool
> builder launcher each time you switch between them (consider for example
> different OSs or different tools doing the same thing). This would come in
> very handy e.g. for teams working on a common source code repository which
> contains the project configuration as well.

Could you create a separate bug for the additional request?
Comment 22 Holger Machens CLA 2013-02-06 12:01:57 EST
Latter enhancement request moved into seperate enhancement request (Bug: 400126).
Comment 23 Christian Ungur CLA 2014-04-15 05:53:48 EDT
Is this really such a toughie?
Comment 24 Martin Oberhuber CLA 2015-09-22 09:15:09 EDT
Created attachment 256759 [details]
testprojects

This is still a problem with Mars, exactly as described in comment #0 .
The limitation seems totally artificial since the following workaround works:

Project1 > Properties > Builders, New, "testbuilder", Save
Project2 > Properties > Builders, New, "testbuilder"
   --> Error: A 'Program' configuration with that name already exists.

After CLOSING Project1 the "testbuilder" can be added and seems to work OK.
Also, when IMPORTING attached projects, the builders seem to work OK.

Can the team confirm that this workaround is acceptable ?
And could the odd UI limitation be finally lifted?

CQ:WIND00-WB3-51391
Comment 25 Sarika Sinha CLA 2015-09-23 06:17:29 EDT
Going through the patch from Comment #15, I think we are stuck for multiple resources scenario