Bug 578927 - [Accessibility] Sourceviewer has almost no contrast in High Contrast Theme
Summary: [Accessibility] Sourceviewer has almost no contrast in High Contrast Theme
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.24   Edit
Hardware: PC Windows All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-23 06:29 EST by Marcus Höpfner CLA
Modified: 2022-02-24 03:21 EST (History)
1 user (show)

See Also:

Attachments
high_contrast_sourceviewer.png (26.83 KB, image/png)
2022-02-23 06:29 EST, Marcus Höpfner CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Höpfner CLA 2022-02-23 06:29:00 EST 
Created attachment 288109 [details]
high_contrast_sourceviewer.png

Refer to the attachment.

Setup is Windows in high contrast mode and Eclipse running with light theme.

The line with the caret is really, really hard to read. I didn't do any selection, it is just the line which is currently edited.
Comment 1 Marcus Höpfner CLA 2022-02-23 07:08:30 EST 
I think it is occurring only in the SourceViewer. Not in underlying StyledText since Styledtext has no line highlighting.

Any idea how this can be fixed? Maybe I can give it a try.
Comment 2 Thomas Wolf CLA 2022-02-24 02:53:42 EST 
I don't understand. The image looks like dark mode?

I have the impression it somehow uses the line highlighting color from light mode. Maybe related to bug 577912 or bug 565967.
Comment 3 Marcus Höpfner CLA 2022-02-24 03:19:05 EST 
(In reply to Thomas Wolf from comment #2)
> I don't understand. The image looks like dark mode?
> 
> I have the impression it somehow uses the line highlighting color from light
> mode. Maybe related to bug 577912 or bug 565967.

It is high contrast mode in windows (can be set in the settings). This is something different than dark mode in eclipse.
Eclipse is still in light mode.
Comment 4 Marcus Höpfner CLA 2022-02-24 03:21:02 EST 
(In reply to Thomas Wolf from comment #2)
> I don't understand. The image looks like dark mode?
> 
> I have the impression it somehow uses the line highlighting color from light
> mode. Maybe related to bug 577912 or bug 565967.

(In reply to Marcus Höpfner from comment #3)
> (In reply to Thomas Wolf from comment #2)
> > I don't understand. The image looks like dark mode?
> > 
> > I have the impression it somehow uses the line highlighting color from light
> > mode. Maybe related to bug 577912 or bug 565967.
> 
> It is high contrast mode in windows (can be set in the settings). This is
> something different than dark mode in eclipse.
> Eclipse is still in light mode.

I don't think the bugs are related.
This seems to be really an issue with high contrast mode.
Eclipse even recognizes the high contrast switch and ask for restart.
But somehow the line color is wrong.