Community
Participate
Working Groups
Created attachment 283825 [details] Unreadable text selection in compare editor On macOS, some text areas seem to ignore the selection foreground and background colors defined by CSS themes. I've noticed this in at least two places: * when using the default compare editor. * when using the Subclipse plugin (https://github.com/subclipse/subclipse) and selecting text in the commit message dialog. Attached is a screenshot of the first case when using the built-in Dark theme. As you can see, selected text is unreadable when comparing two files for example. Note that I'm using macOS Catalina 10.15.6 with Openjdk 11.0.8 2020-07-14.
Created attachment 283953 [details] Hard to read text selection in save actions list Another place where this is noticeable: the save actions list from the JDT UI preferences.
The effects are still the same with the standard dark theme on: Build id: I20201028-0800 macOS 11: 11.0.1 Beta (20B5012d)
Sounds like this is an SWT issue.
I see the correct selection background color in SWT in dark theme, but the color used in Eclipse is that of light theme. Is it related to Bug 577912?
(In reply to Lakshmi P Shanmugam from comment #4) > I see the correct selection background color in SWT in dark theme, but the > color used in Eclipse is that of light theme. Is it related to Bug 577912? I don't think so. I see this in the text compare (selection background light blue), but not in the Java compare (dark blue).
On second thought, perhaps it is. Is bug 531820 also related?
(In reply to Thomas Wolf from comment #6) > On second thought, perhaps it is. Is bug 531820 also related? Yes, the problem is that SWT color constant being returned is of light theme though Eclipse is in dark theme.
(In reply to Lakshmi P Shanmugam from comment #7) > (In reply to Thomas Wolf from comment #6) > > On second thought, perhaps it is. Is bug 531820 also related? > > Yes, the problem is that SWT color constant being returned is of light theme > though Eclipse is in dark theme. But why only in text compare but not in Java compare?
(In reply to Thomas Wolf from comment #8) > (In reply to Lakshmi P Shanmugam from comment #7) > > (In reply to Thomas Wolf from comment #6) > > > On second thought, perhaps it is. Is bug 531820 also related? > > > > Yes, the problem is that SWT color constant being returned is of light theme > > though Eclipse is in dark theme. > > But why only in text compare but not in Java compare? In Bug 531820, JDISourceViewer uses constants from AbstractTextEditor for background and foreground instead of SWT Color constants. JavaBreakpointConditionEditor was using a SWT Color constant and was removed to fix the problem. Could be similar for Java compare where different color constants for selection background are used.
