Community
Participate
Working Groups
Created attachment 272944 [details] Screenshot See screenshot, in the Breakpoints view I frequently see a white stripe. If I select this view, this part of the view gets re-styled. I suspect a hard-coded color or an error in SWT.
Till, do you also see this on Mac?
(In reply to Lars Vogel from comment #1) > Till, do you also see this on Mac? I've never previously noticed, but yes I have something similar. There are some breakpoints which keep the current (styled or unstyled) state from the previous breakpoint and some that make it switch to white or styled. I think it is not a matter of focus, but whether the condition checkbox is enabled or something like that.
*** Bug 576103 has been marked as a duplicate of this bug. ***
New Gerrit change created: https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/190973
(In reply to Eclipse Genie from comment #4) > New Gerrit change created: > https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/190973 JDT debug was using SWT.COLOR_WIDGET_BACKGROUND to get the colour to set, but this constant gives white instead of grey for dark theme. Using AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND looks ok on light and sark themes.
Sarika, something for RC1 or do you want to wait until 4.24 opens?
(In reply to Lars Vogel from comment #6) > Sarika, something for RC1 or do you want to wait until 4.24 opens? Ideally SWT.COLOR_WIDGET_BACKGROUND should have given the correct colour. So if SWT has plans to correct that we don't need to release Debug workaround patch but if SWT is not fixing in near time I am ok to release this fix for RC1. @Lakshmi, WDYT?
(In reply to Lars Vogel from comment #6) > Ideally SWT.COLOR_WIDGET_BACKGROUND should have given the correct colour. > So if SWT has plans to correct that we don't need to release Debug > workaround patch but if SWT is not fixing in near time I am ok to release > this fix for RC1. > > @Lakshmi, > WDYT? I think the colors issue with SWT late / wrong initialization is Bug 577912, which is IMHO too complex to include it into 4.23.
(In reply to Lars Vogel from comment #8) > (In reply to Lars Vogel from comment #6) > > > Ideally SWT.COLOR_WIDGET_BACKGROUND should have given the correct colour. > > So if SWT has plans to correct that we don't need to release Debug > > workaround patch but if SWT is not fixing in near time I am ok to release > > this fix for RC1. > > > > @Lakshmi, > > WDYT? > > I think the colors issue with SWT late / wrong initialization is Bug 577912, > which is IMHO too complex to include it into 4.23. @Lars, thanks for pointing to the bug. I was seeing another problem with selection colors and could be same root cause. @Sarika, I checked with ControlExample and SWT.COLOR_WIDGET_BACKGROUND is having the correct value for dark theme. So, it seems like the initialization problem as Lars pointed out. If possible, please release this for RC1.
Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/190973 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=32039d271ae35c499864a36d83f38d0f0f5b2705
(In reply to Eclipse Genie from comment #10) > Gerrit change https://git.eclipse.org/r/c/jdt/eclipse.jdt.debug/+/190973 was > merged to [master]. > Commit: > http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/ > ?id=32039d271ae35c499864a36d83f38d0f0f5b2705 This patch removes the setting of background colour as currently SWT constant returns white instead of grey for background colour in dark theme.
Verified on Win10 using Build id: I20220221-1800
