Bug 578916 - [MinMax] Hidden part not shown when activated if trimbars are hidden
Summary: [MinMax] Hidden part not shown when activated if trimbars are hidden
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.22   Edit
Hardware: PC All
: P3 normal with 1 vote (vote)
Target Milestone: 4.24 M3   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-22 15:21 EST by Rolf Theunissen CLA
Modified: 2022-04-07 01:58 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Theunissen CLA 2022-02-22 15:21:46 EST
From bug 578844 Comment 5

> I tried with a new install of 2022-12, package "Eclipse IDE for Java
> Developers". The problem persists.
> 
> Steps to reproduce:
> - start eclipse with a new workspace
> - create Java project
> - create a Java class with a main method
> - Make sure that Java class is opened and the editor has the focus
> - Ctrl-M to maximize the editor area
> - Ctrl-3, choose "Toggle visibility of the window toolbars" - the little
> toolbar icons disappear
> - Select an identifier, say String or main, and invoke Ctrl-Shift-G to find
> references in workspace ==> nothing happens
> - Press Ctrl-M to un-maximize the editor area again ==> nothing happens
> - Ctrl-3, choose "Toggle visibility of the window toolbars"
> - Press Ctrl-Shift-G or Ctrl-M as before - now the functions work as expected

That I notice from this:
When all toolbars are hidden, also the icons for the hidden views are hidden.
The Ctrl-Shift-G operation moves focus to the Search view, however this view is not shown. As a result the focus is on a hidden view. The view is not shown because the toolbars are hidden.

For this case, there is a bad interaction between the toggle all-toolbars and MinMax addon.


This test case must have been missed or broken from Bug 427999 Comment 14.

Problem is that in TrimStack#getCAComposite the Limbo Shell is returned as shell of the trimStackTB. This makes sense as trimStackTB is hidden.
Comment 1 Eclipse Genie CLA 2022-02-22 16:04:00 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/191075