Bug 578844 - Toggle visibility of window toolbars/main toolbar/status bar have strange interferences
Summary: Toggle visibility of window toolbars/main toolbar/status bar have strange int...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.23   Edit
Hardware: PC Windows 10
: P3 normal with 1 vote (vote)
Target Milestone: 4.23 RC1   Edit
Assignee: Wim Jongman CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-19 03:30 EST by Dirk Steinkamp CLA
Modified: 2022-02-22 15:34 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Steinkamp CLA 2022-02-19 03:30:52 EST
I'm facing some strange interferences and anomalies while using the options above.

(Background: I was wondering how to achieve a kind of "zen mode" in Eclipse and came up with combining "full screen/maximize editor/hide toolbars/hide status bar" might do the trick ...)

Things I notices:

* "Toggle visibility of status bar" does hide the status bar, but not show it again when invoked a second time. It does show again if I e.g. toggle the main toolbar or maximize the window. --> looks like a refresh of the window is missing here

*  "Toggle visibility of the window toolbars" does also hide the main toolbar, yet a subsequent "toggle main toolbar visibility" does not bring the main toolbar back to visibility, but seems to confirm the state "it should really be hidden". Calling "toggle main toolbar visibility" again then makes the main toolbar visible again.

* "Toggle visibility of the window toolbar" has a very annoying side effect: it blocks other views to show up when invoked by keyboard. E.g. if I press Ctrl-Shift-G in a Java Editor to find references in the workspace I would expect the view with the found references to show up. Yet nothing happens! I have to enable the visibility of the window toolbar again, before I can actually use this keyboard shortcut again. (While this might ensure my intended "Zen mode" to actually be only focused on my current code, it's more focus than I was looking for ;-)...)

I was not sure if I should create one or several issues for this, as these things seem to be somewhat strangely interrelated.
Comment 1 Eclipse Genie CLA 2022-02-19 05:58:48 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/190978
Comment 2 Wim Jongman CLA 2022-02-19 06:00:07 EST
You were right that these were related. However, I cannot duplicate your issue with disabled shortcut keys.
Comment 3 Dirk Steinkamp CLA 2022-02-19 07:12:23 EST
(In reply to Wim Jongman from comment #2)
> You were right that these were related. However, I cannot duplicate your
> issue with disabled shortcut keys.

I will try a vanilla installation of eclipse and report back if the issue persists then (I already tried on two different machines though with 4.22 and 4.23M2).
Comment 4 Dirk Steinkamp CLA 2022-02-19 15:43:33 EST
(In reply to Dirk Steinkamp from comment #3)
> (In reply to Wim Jongman from comment #2)
> > You were right that these were related. However, I cannot duplicate your
> > issue with disabled shortcut keys.
> 
> I will try a vanilla installation of eclipse and report back if the issue
> persists then (I already tried on two different machines though with 4.22
> and 4.23M2).

I tried with a new install of 2022-12, package "Eclipse IDE for Java Developers". The problem persists.

Steps to reproduce:
- start eclipse with a new workspace
- create Java project
- create a Java class with a main method
- Make sure that Java class is opened and the editor has the focus
- Ctrl-M to maximize the editor area
- Ctrl-3, choose "Toggle visibility of the window toolbars" - the little toolbar icons disappear
- Select an identifier, say String or main, and invoke Ctrl-Shift-G to find references in workspace ==> nothing happens
- Press Ctrl-M to un-maximize the editor area again ==> nothing happens
- Ctrl-3, choose "Toggle visibility of the window toolbars"
- Press Ctrl-Shift-G or Ctrl-M as before - now the functions work as expected
Comment 5 Rolf Theunissen CLA 2022-02-22 06:01:39 EST
(In reply to Dirk Steinkamp from comment #4)
> (In reply to Dirk Steinkamp from comment #3)
> > (In reply to Wim Jongman from comment #2)
> > > You were right that these were related. However, I cannot duplicate your
> > > issue with disabled shortcut keys.
> > 
> > I will try a vanilla installation of eclipse and report back if the issue
> > persists then (I already tried on two different machines though with 4.22
> > and 4.23M2).
> 
> I tried with a new install of 2022-12, package "Eclipse IDE for Java
> Developers". The problem persists.
> 
> Steps to reproduce:
> - start eclipse with a new workspace
> - create Java project
> - create a Java class with a main method
> - Make sure that Java class is opened and the editor has the focus
> - Ctrl-M to maximize the editor area
> - Ctrl-3, choose "Toggle visibility of the window toolbars" - the little
> toolbar icons disappear
> - Select an identifier, say String or main, and invoke Ctrl-Shift-G to find
> references in workspace ==> nothing happens
> - Press Ctrl-M to un-maximize the editor area again ==> nothing happens
> - Ctrl-3, choose "Toggle visibility of the window toolbars"
> - Press Ctrl-Shift-G or Ctrl-M as before - now the functions work as expected

That I notice from this:
When all toolbars are hidden, also the icons for the hidden views are hidden.
The Ctrl-Shift-G operation moves focus to the Search view, however this view is not shown. As a result the focus is on a hidden view. The view is not shown because the toolbars are hidden.

For this case, there is a bad interaction between the toggle all-toolbars and MinMax addon.
Comment 6 Rolf Theunissen CLA 2022-02-22 06:04:57 EST
That must be a regression from Bug 427999
Comment 8 Wim Jongman CLA 2022-02-22 10:01:57 EST
Dirk, please file another issue for the shortcut keys.
Comment 9 Rolf Theunissen CLA 2022-02-22 15:22:14 EST
(In reply to Wim Jongman from comment #8)
> Dirk, please file another issue for the shortcut keys.

I created Bug 578916
Comment 10 Dirk Steinkamp CLA 2022-02-22 15:34:27 EST
@Wim: Thanks for the fix
@Rolf: Thanks for the follow-up-issue

Question: I had a look into the commit, and it does seem to address the first issue, but not the second:

> "Toggle visibility of the window toolbars" does also hide the main toolbar, 
> yet a subsequent "toggle main toolbar visibility" does not bring the main 
> toolbar back to visibility, but seems to confirm the state "it should really 
> be hidden". Calling "toggle main toolbar visibility" again then makes the 
> main toolbar visible again.

Am I missing something, or do you agree that's not addressed yet? If so: shall I create another issue for that, too?