Bug 576218 - Over 99 tab indicator has lost the +
Summary: Over 99 tab indicator has lost the +
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.21   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 4.22 M2   Edit
Assignee: Niraj Modi CLA
QA Contact: Jörg Kubitz CLA
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks: 574641
  Show dependency tree
 
Reported: 2021-09-23 05:40 EDT by Alain Picard CLA
Modified: 2021-10-11 02:57 EDT (History)
4 users (show)

See Also:

Attachments
Screenshot of issue (1.03 KB, image/png)
2021-09-23 05:40 EDT, Alain Picard CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alain Picard CLA 2021-09-23 05:40:46 EDT 
Created attachment 287195 [details]
Screenshot of issue

When you have more than 99 hidden tabs, you use to see a + sign.

In the latest version this shows up as a small dot (.)

See image
Comment 1 Rolf Theunissen CLA 2021-09-24 02:40:57 EDT 
It seems that the most of the + sign is cut of, and only a dot is visible.

Might be a regression of Bug 575553.
Comment 2 Rolf Theunissen CLA 2021-09-26 11:40:13 EDT 
After investigation, this is a regression of Bug 574641, when that change is reversed the full label is visible again.
Comment 3 Eclipse Genie CLA 2021-09-26 17:02:05 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/185837
Comment 4 Andrey Loskutov CLA 2021-10-01 10:37:07 EDT 
(In reply to Eclipse Genie from comment #3)
> New Gerrit change created:
> https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/185837

Does this also fix bug 576178? If yes, bug 576178 should be made duplicate of this one. If not, please also check bug 576178 regression.
Comment 6 Niraj Modi CLA 2021-10-07 07:48:44 EDT 
In-fact all ToolItem#setXXX() methods need to call parent.layout(boolean) which makes the cached ToolBar size invalid.
Planning to share another gerrit shortly(as part2 fix for this bug 576218)
Comment 7 Eclipse Genie CLA 2021-10-07 07:57:20 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/186277
Comment 9 Niraj Modi CLA 2021-10-11 02:57:30 EDT 
(In reply to Eclipse Genie from comment #8)
> Gerrit change
> https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/186277 was
> merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=eabde3040afaf3d0a069a28d4e392b004307eccc

Resolving now.