Bug 575809 - Quickaccess shows MParts that are not Views
Summary: Quickaccess shows MParts that are not Views
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.20   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-03 06:17 EDT by Mathias Mehrmann CLA
Modified: 2021-09-03 06:17 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Mehrmann CLA 2021-09-03 06:17:33 EDT 
While running into Bug#575329 we also detected, that quickaccess still showed the Views. But also MParts that are not defined as Views (-> Editors!).

Shouldn't it be concistent with ShowViewDialog which is using isView()?

MParts that do not have a View Tag or in our case MParts that are only defined with an Editor View tag are also showing up in quickaccess and we did not expect those Parts to be used in that case.

Worse: if you select such an editor in the quickaccess, this editor is under some circumstances not closeable in any way...

org.eclipse.ui.internal.quickaccess.providers.ViewProvider.getElements() should also filter with isView() like in org.eclipse.ui.internal.dialogs.ViewContentProvider.isView(MPartDescriptor)