Bug 575329 - Plugins created with 'View contribution using 4.x API' are not working in Eclipse 2021-06
Summary: Plugins created with 'View contribution using 4.x API' are not working in Ecl...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.20   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 4.21 M3   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-08-10 04:01 EDT by Staszek Kulczycki CLA
Modified: 2021-08-18 03:54 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Staszek Kulczycki CLA 2021-08-10 04:01:57 EDT 
When I create a plugin with 'View contribution using 4.x API' it does not show up after launching the app in Window -> View -> Others...

It looks like a regression as it works fine in Eclipse 2021-03 and 2020-12
This issue is similar to: https://bugs.eclipse.org/bugs/show_bug.cgi?id=514331

Tested packages:
eclipse-committers-2021-06-R-win32-x86_64.zip - not working
eclipse-committers-2021-03-R-win32-x86_64.zip - works
eclipse-committers-2020-12-R-win32-x86_64.zip - works

Menu and Toolbar '4.x' contributions are now showing up as well.
Comment 1 Vikas Chandra CLA 2021-08-12 06:55:51 EDT 
It works on Version: 2021-06 (4.20) Build id: I20210320-0650 but not on eclipse-SDK-I20210331-1800-linux-gtk-x86_64
Comment 2 Vikas Chandra CLA 2021-08-12 06:57:00 EDT 
@Lars, any idea on this one?
Comment 3 Andrey Loskutov CLA 2021-08-12 07:03:38 EDT 
Most likely related to bug 569108.
Comment 4 Lars Vogel CLA 2021-08-12 07:05:14 EDT 
Most likely the the app model is saved and the template only use apply "initial".

Does it work if you are using the -clearPersistedState flag in your runtime configuration?
Comment 5 Lars Vogel CLA 2021-08-12 07:13:43 EDT 
For (In reply to Andrey Loskutov from comment #3)
> Most likely related to bug 569108.

This was a better hint. From looking at the Gerrit in this bug, the filtering seems not ignore non plug-in based views. Hannes, can you have a look?
Comment 6 Vikas Chandra CLA 2021-08-12 13:06:05 EDT 
(In reply to Andrey Loskutov from comment #3)
> Most likely related to bug 569108.

Reverting the fix there fixes this issue.
Comment 7 Vikas Chandra CLA 2021-08-16 03:38:23 EDT 
Since this is a regression, it is better to fix this by M3 ( this is the M3 testing/declare week). If not fixed by EOD, I will have to revert the commit that caused this issue.
Comment 8 Vikas Chandra CLA 2021-08-17 02:48:41 EDT 
revert commit-> https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/183775
Comment 9 Mickael Istria CLA 2021-08-17 02:59:54 EDT 
IMO, let's revert right now and reopen bug 569108 and ensure it contains a test about pure e4 views.
Comment 10 Vikas Chandra CLA 2021-08-17 03:04:01 EDT 
(In reply to Mickael Istria from comment #9)
> IMO, let's revert right now and reopen bug 569108 and ensure it contains a
> test about pure e4 views.

+1
Comment 11 Vikas Chandra CLA 2021-08-17 03:06:41 EDT 
I will test comment#0 with tomorrow's build
Comment 13 Vikas Chandra CLA 2021-08-18 03:54:31 EDT 
verified on
Version: 2021-09 (4.21)
Build id: I20210817-0600