Description Hannes Niederhausen 2020-11-24 04:34:34 EST

Hi,

I deactivated some views using activity patterns. Although I can't open them the ShowViewsDialog lists the disabled views.

I found the problem in the ContentProvider of the TreeViewer.

ViewContentProvider#isFilteredByActivity checks whether the given view id is filtered. However, it uses  viewRegistry.getViews() to find the view for the given id. getViews() is already filtering out disabled views, therefore the content provider can't find the view with the id to check and defaults to "unfiltered".

I see two solutions:
Either extend isFilteredByActivity so it also returns true if the view wasn't found or use the viewRegistry in the methods determineTopLevelElements and determineViewsInCategory instead of application.getDescriptors().