Community
Participate
Working Groups
While running into Bug#575329 we also found some discrepancies in our E4 Part definitions. We had E4 parts that did not have a "View" Tag. But they had set a Category. Normally org.eclipse.ui.internal.dialogs.ShowViewDialog will filter out MParts that are not a View (!isView(descriptor)). But if you have a MPart which is a View and has the same category as a MPart that does not have it, this Non-View-MPart will also show up in that Category. It's a wrong definition on our side that we already solved but also a possible inconcistency that costs us some time to find the problem. org.eclipse.ui.internal.dialogs.ViewContentProvider.determineTopLevelElements(Object) is using !isView(descriptor) org.eclipse.ui.internal.dialogs.ViewContentProvider.determineViewsInCategory(String) is not using it. Wouldn't it be better if both locations react in the same way?
(In reply to Mathias Mehrmann from comment #0) > While running into Bug#575329 we also found some discrepancies in our E4 > Part definitions. > > We had E4 parts that did not have a "View" Tag. > But they had set a Category. > > Normally org.eclipse.ui.internal.dialogs.ShowViewDialog will filter out > MParts that are not a View (!isView(descriptor)). > > But if you have a MPart which is a View and has the same category as a MPart > that does not have it, this Non-View-MPart will also show up in that > Category. > > It's a wrong definition on our side that we already solved but also a > possible inconcistency that costs us some time to find the problem. > > org.eclipse.ui.internal.dialogs.ViewContentProvider. > determineTopLevelElements(Object) > is using !isView(descriptor) > > org.eclipse.ui.internal.dialogs.ViewContentProvider. > determineViewsInCategory(String) > is not using it. > > Wouldn't it be better if both locations react in the same way? Sounds reasonable. Please provide a Gerrit.
