Bug 575402 - [GTK] Line number ruler painting broken
Summary: [GTK] Line number ruler painting broken
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.21   Edit
Hardware: PC Linux
: P3 blocker (vote)
Target Milestone: 4.21 M3   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 568859
  Show dependency tree
 
Reported: 2021-08-13 11:07 EDT by Andrey Loskutov CLA
Modified: 2021-08-14 02:05 EDT (History)
5 users (show)

See Also:

Attachments
screen recording on RHEL 7.4 / GTK 3.22 (5.80 MB, video/mp4)
2021-08-13 11:24 EDT, Andrey Loskutov CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2021-08-13 11:07:53 EDT 
Some SWT change in I20210812-1800 caused severe regression in the IDE on GTK/Linux.

Line number ruler doesn't properly repaint itself anymore.
Open String class, scroll to the middle, scroll back and forth with the mouse wheel, line numbers are completely corrupt (duplicated, overpainted, partly painted etc).

Unfortunately build I20210812-1800 had multiple severe changes, not sure which one caused regression. Switching SWT/binaries to v4946r18 tag fixes the problem.

Possible candidates:

Bug 575044: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183906
Bug 539524: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183706
Bug 539524: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183457
Bug 568859: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/172497

This must be fixed for M3 next week!
Comment 1 Alexander Kurtakov CLA 2021-08-13 11:10:14 EDT 
Can you show screenshow/screencast what/how is broken? I don't see breakage on my Fedora 34.
Comment 2 Alexander Kurtakov CLA 2021-08-13 11:11:42 EDT 
If I'm to guess https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/172497 should be the cause. Can you try reverting this one and test whether it fixes for you?
Comment 3 Andrey Loskutov CLA 2021-08-13 11:24:55 EDT 
Created attachment 286940 [details]
screen recording on RHEL 7.4 / GTK 3.22

Yep, this seem to be bug 568859. After revert + SWT rebuild IDE works fine again.
Comment 4 Andrey Loskutov CLA 2021-08-13 11:33:05 EDT 
Here is the revert:
https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183997

I've verified, that with SWT rebuilt with this commit, IDE works properly again.
Comment 5 Andrey Loskutov CLA 2021-08-14 02:05:20 EDT 
Fixed in I20210813-1800.
Comment 6 Andrey Loskutov CLA 2021-08-14 02:05:49 EDT 
Verified in I20210813-1800.