Bug 575069 - [GTK] Disabled toolbar/button/menu images have poor quality
Summary: [GTK] Disabled toolbar/button/menu images have poor quality
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.21   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.21 M2   Edit
Assignee: Simeon Andreev CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-07-27 09:17 EDT by Simeon Andreev CLA
Modified: 2021-07-29 04:03 EDT (History)
3 users (show)

See Also:

Attachments
Showcasing the image of a disabled ToolItem with Eclipse 4.21. The disabled effect is of poor quality, compared to the equivalent done by GTK3. (9.84 KB, image/png)
2021-07-27 09:17 EDT, Simeon Andreev CLA 		no flags Details
Showcasing the image of a disabled ToolItem with Eclipse 4.16. The greying out is done by GTK3. (10.78 KB, image/png)
2021-07-27 09:18 EDT, Simeon Andreev CLA 		no flags Details
Disabled ToolItem icons on Eclipse 3.8.2, with GTK2. (16.21 KB, image/png)
2021-07-28 02:49 EDT, Simeon Andreev CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simeon Andreev CLA 2021-07-27 09:17:45 EDT 
Created attachment 286835 [details]
Showcasing the image of a disabled ToolItem with Eclipse 4.21. The disabled effect is of poor quality, compared to the equivalent done by GTK3.

See attached screenshots "disabled_toolbar_icons_e416.png" and "disabled_toolbar_icons_e421.png".

See also bug 568771 and linked tickets. Before Eclipse 4.17, GTK3 would do the disabled effect of icons. With Eclipse 4.17+, this is done by SWT and the quality is lower.
Comment 1 Simeon Andreev CLA 2021-07-27 09:18:18 EDT 
Created attachment 286836 [details]
Showcasing the image of a disabled ToolItem with Eclipse 4.16. The greying out is done by GTK3.
Comment 2 Eclipse Genie CLA 2021-07-27 11:14:09 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183407
Comment 3 Simeon Andreev CLA 2021-07-28 02:49:29 EDT 
Created attachment 286839 [details]
Disabled ToolItem icons on Eclipse 3.8.2, with GTK2.
Comment 5 Andrey Loskutov CLA 2021-07-29 04:03:05 EDT 
Works fine in I20210728-1800.