Community
Participate
Working Groups
Created attachment 286536 [details] Picture showing how unreadable highlighted items are When I upgraded Eclipse to the latest version I started having this issue seen in the attached screenshot. It used to work fine with 2020-03 but with 2021 versions you cannot read highlighted items in package explorer, Ant, and History views (among others). The DevStyle people said it was out of their control, it was an Eclipse bug with the latest versions running on Windows 7. How do I change that background (or foreground) color so that it's not grey on grey?
Wayne, do you see the same issue in the default dark theme of the platform?
Reported originally in the forums at [1], where Ed Merks wrote he saw the same problem with the default dark theme on Windows 7. [1] https://www.eclipse.org/forums/index.php/t/1108145/
Created attachment 286543 [details] Unreadable dark theme selections in Windows 7
I don't think this color can be styled, moving to SWT.
Is Win7 still supported my MS?
No, Windows 7 is end of life.
The dark theme issues are not only for Windows 7, on Windows 10 there are many known issues w.r.t selection and the dark theme too: Bug 564960, Bug 566280, Bug 566281
What is SWT?
(In reply to Wayne Baldwin from comment #8) > What is SWT? The widget toolkit Eclipse uses. https://www.eclipse.org/swt/ .
(In reply to Lars Vogel from comment #4) > I don't think this color can be styled, moving to SWT. Request for CSS customization was in Bug 434309, it was implemented (and marked as greatfix). However, it is removed in Bug 562865 (together with broken custom arrow code).
(In reply to Rolf Theunissen from comment #10) > (In reply to Lars Vogel from comment #4) > Request for CSS customization was in Bug 434309, it was implemented (and > marked as greatfix). However, it is removed in Bug 562865 (together with > broken custom arrow code). Did you test if the fix from https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f014a8c0f49b656bc40d5cd1d25c5b7a81bf2630 works without bad side effects? IIRC it was removed because the custom drawing was creating blurry text in multiple dialogs / popups. Also the creator of the fix was not reacting to request on this custom draing code. So whoever wants to restore this code should also be ready to look into bug reports in this area. Bug 566281 sounds like an issue with Windows SWT and not something we should try to overpaint in the CSS engine.
There are actually TWO colors here, background and foreground, are both controlled by SWT? How can so many other colors be customized but NOT selected items?
(In reply to Lars Vogel from comment #11) > (In reply to Rolf Theunissen from comment #10) > > (In reply to Lars Vogel from comment #4) > > > Request for CSS customization was in Bug 434309, it was implemented (and > > marked as greatfix). However, it is removed in Bug 562865 (together with > > broken custom arrow code). > > Did you test if the fix from > https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=f014a8c0f49b656bc40d5cd1d25c5b7a81bf2630 works without bad side effects? > IIRC it was removed because the custom drawing was creating blurry text in > multiple dialogs / popups. Also the creator of the fix was not reacting to > request on this custom draing code. So whoever wants to restore this code > should also be ready to look into bug reports in this area. > > Bug 566281 sounds like an issue with Windows SWT and not something we should > try to overpaint in the CSS engine. I did only have a quick look at the code, I did not notice it uses the custom painter in this version already. I agree with you that this is best made customizable in SWT.
(In reply to Wayne Baldwin from comment #12) > There are actually TWO colors here, background and foreground, are both > controlled by SWT? How can so many other colors be customized but NOT > selected items? It seems not to complex, but so far nobody was annoyed enough to be willing to pay to implement this (either in time or money). For me, I don't have the time to fix it so I just stick with the light theme, such that I am not annoyed. Given that this is an open source project, the DevStyle people are in control too, it is open for them to provide fixes to the issues they encounter.
(In reply to Rolf Theunissen from comment #14) > (In reply to Wayne Baldwin from comment #12) > > There are actually TWO colors here, background and foreground, are both > > controlled by SWT? How can so many other colors be customized but NOT > > selected items? > > It seems not to complex, but so far nobody was annoyed enough to be willing > to pay to implement this (either in time or money). For me, I don't have the > time to fix it so I just stick with the light theme, such that I am not > annoyed. > > Given that this is an open source project, the DevStyle people are in > control too, it is open for them to provide fixes to the issues they > encounter. The DevStyle people said they have no control over these colors. Are you saying that the SWT is open source? Or is the "CSS Engine" what you are referring to that they could modify like the Bugs above attempted to do but failed?
(In reply to Wayne Baldwin from comment #15) > The DevStyle people said they have no control over these colors. Are you > saying that the SWT is open source? Or is the "CSS Engine" what you are > referring to that they could modify like the Bugs above attempted to do but > failed? All components of Eclipse including SWT are open source. Any interested party could contribute to it so if the DevStyle people want they could fix this at its source. See https://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html for a description for the process and examples how to do this.
I'll comment on behalf of Genuitec since our Darkest Dark product has been referenced in the bug report. I'll first thank the Eclipse committers for looking at the issue and verifying what we found in our internal review. Rolf and Lars are correct that Genuitec could dedicate resources to resolve this issue. However, in our testing we've found that it only affects Darkest Dark on Windows 7, and not the later Windows releases. Since Windows 7 is end-of-life [1] and even Microsoft has stopped supporting it, I regret that we won't be allocating any resources to resolve this issue. If the SWT team also decides to leave it unaddressed, I'll suggest that this issue be closed as WONT-FIX due to affecting only an EOL platform. [1] https://www.microsoft.com/en-US/windows/windows-7-end-of-life-support-information
Windows 7 may be EoL but I continue to get Malicious Software Removal Tool updates and it's a very stable platform to work with literally my work environment. Upgrading my VM to Win 10 may break other tools I rely on not to mention the non stop updates Win 10 forces down your throat at least every five or six weeks which could also break things. Just the slightest change to either background or foreground color would make this much more useable, is there no easy way to tweak on or the other?
Created attachment 286552 [details] Debug View highlights fine So why does the Debug view NOT have the same problem? (see new attachment).
Dark-theme issues seen in attachments(attachment 286536 [details], attachment 286543 [details], attachment 286552 [details]) are not seen any more. IMO, bug 567616 took care of these(may be some other bug as well which I don't recall currently) *** This bug has been marked as a duplicate of bug 567616 ***
This bug is still present so I am not sure why you are closing this. The duplicate is also closed but the problem has not been resolved for me anyway. Installing Win 10 is not an option.
(In reply to Wayne Baldwin from comment #21) > This bug is still present so I am not sure why you are closing this. The > duplicate is also closed but the problem has not been resolved for me > anyway. Installing Win 10 is not an option. Wayne, this bug is being closed because it won't be fixed by the Eclipse committers because Windows 7 is EOL. I addressed Genuitec's similar stance on the issue in Comment #18.
I'll suggest that the Eclipse SWT team change the resolution of this bug from CLOSED DUPLICATE to WONTFIX to avoid further confusion as this is not the same bug #567616 since it only is being reported for Windows 7.
(In reply to Todd E. Williams from comment #23) > I'll suggest that the Eclipse SWT team change the resolution of this bug > from CLOSED DUPLICATE to WONTFIX to avoid further confusion as this is not > the same bug #567616 since it only is being reported for Windows 7. Done.
