Bug 562865 - Remove code for tree/table selection color customization and for arrows on Windows tree
Summary: Remove code for tree/table selection color customization and for arrows on Wi...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.16   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: 4.16 M3   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 465668 562672 (view as bug list)
Depends on: 514288 562689 562781
Blocks:
  Show dependency tree
 
Reported: 2020-05-06 04:36 EDT by Lars Vogel CLA
Modified: 2020-08-22 06:39 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-05-06 04:36:30 EDT 
Commit f014a8c0f49b656bc40d5cd1d25c5b7a81bf2630 introduced codefor a better support for the dark theme. As this is not needed anymore for the dark theme, I suggest to remove that to use SWT functionality directly here.
Comment 1 Andrew Obuchowicz CLA 2020-05-06 11:19:28 EDT 
I'm not exactly sure which CSS preferences you're referring to (haven't checked the commmit) but couldn't this functionality still be useful for theme creators? Or is it now possible to use the same functionality, but natively through SWT?
Comment 2 Lars Vogel CLA 2020-05-06 11:32:51 EDT 
(In reply to Andrew Obuchowicz from comment #1)
> I'm not exactly sure which CSS preferences you're referring to (haven't
> checked the commmit) but couldn't this functionality still be useful for
> theme creators? Or is it now possible to use the same functionality, but
> natively through SWT?

Theme creators can still implement this if they want using their own CSS handler.
Comment 3 Lars Vogel CLA 2020-05-13 11:10:52 EDT 
*** Bug 465668 has been marked as a duplicate of this bug. ***
Comment 4 Lars Vogel CLA 2020-05-13 11:11:36 EDT 
We also have also to revert https://git.eclipse.org/r/#/c/45295/
Comment 5 Lars Vogel CLA 2020-05-13 11:11:42 EDT 
*** Bug 562672 has been marked as a duplicate of this bug. ***
Comment 6 Eclipse Genie CLA 2020-05-13 11:21:06 EDT 
New Gerrit change created: https://git.eclipse.org/r/162970
Comment 7 Pierre-Yves Bigourdan CLA 2020-05-13 13:18:27 EDT 
(In reply to Andrew Obuchowicz from comment #1)
> couldn't this functionality still be useful for theme creators?

Agreed, I'm guessing you had your https://github.com/AObuchow/Eclipse-Modern-Dark-Theme in mind. I was also making use of this in the custom theme I was playing around with, will see how it looks with native highlights instead. Other options were removed recently, for instance the Styled text scrollbars, it's a shame to see all this go away. The popular DevStyle plugin will probably be impacted as well, there may be others.


I understand the benefits of having less code to maintain in the Platform, but do keep in mind that removing customisation support does make things harder for theme creators as a side effect. ;)
Comment 8 Lars Vogel CLA 2020-05-13 13:38:46 EDT 
The code in question caused serious regressions, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=562689
Comment 9 Lars Vogel CLA 2020-05-15 07:22:56 EDT 
Gerrit update seems to be broken. This one is fixed.

I'm really glad we finally found the reason for the blurry text display in the dark theme for Windows. This made the usage of the dark theme under Windows impossible for me.