Bug 562689 - [win32] Text duplicated/shadowed in several views
Summary: [win32] Text duplicated/shadowed in several views
Status: CLOSED DUPLICATE of bug 561896
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.16   Edit
Hardware: PC Windows 10
: P3 major (vote)
Target Milestone: 4.16 M3   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
: 562989 563095 (view as bug list)
Depends on: 559434
Blocks: 562865
  Show dependency tree
 
Reported: 2020-05-01 09:23 EDT by Gayan Perera CLA
Modified: 2020-05-17 06:01 EDT (History)
10 users (show)

See Also:


Attachments
DebugView (11.39 KB, image/png)
2020-05-01 09:23 EDT, Gayan Perera CLA
no flags Details
Inspections (18.53 KB, image/png)
2020-05-01 09:23 EDT, Gayan Perera CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gayan Perera CLA 2020-05-01 09:23:37 EDT
Created attachment 282650 [details]
DebugView

Text overlapping in several views
Screenshots are provided for:
- Debug View
- Variable Inspection view (Variable Hover)
Comment 1 Gayan Perera CLA 2020-05-01 09:23:57 EDT
Created attachment 282651 [details]
Inspections
Comment 2 Rolf Theunissen CLA 2020-05-01 11:01:33 EDT
I have seen this too in the debug view. It seems to appear and disappear automatically again.
Comment 3 Andrey Loskutov CLA 2020-05-09 13:32:44 EDT
*** Bug 562989 has been marked as a duplicate of this bug. ***
Comment 4 Andrey Loskutov CLA 2020-05-09 15:58:12 EDT
Bug 562989 was also aboud debugger. 
Sarika, is this may be really specific to debug views only? 
Anyone observed this bug on non-debug related views? 
(Haven't seen yet on Linux, nowhere).
Comment 5 Rolf Theunissen CLA 2020-05-10 06:03:04 EDT
The distortion for the inspections occur only (and always) when there is a vertical scrollbar and no horizontal scrollbar in the inspections popup top part, as show in the attachment.
Comment 6 Sarika Sinha CLA 2020-05-11 03:22:32 EDT
(In reply to Andrey Loskutov from comment #4)
> Bug 562989 was also aboud debugger. 
> Sarika, is this may be really specific to debug views only? 
> Anyone observed this bug on non-debug related views? 
> (Haven't seen yet on Linux, nowhere).

I have not seen this on Mac (even with scroll bars)

I will try on Windows 10.
Comment 7 Sarika Sinha CLA 2020-05-12 07:17:22 EDT
*** Bug 563095 has been marked as a duplicate of this bug. ***
Comment 8 Andrey Loskutov CLA 2020-05-12 07:55:05 EDT
There were not so much changes in SWT win32 code. Bug 444560 was about scrollbars, and Rolf mentioned scrollbars to be related? Bug 562126, bug 562165, bug 562330 were there too. 

But most likely this is a regression from bug 444560.

Is this always reproducible on Windows? Comment 5?
Comment 9 Noopur Gupta CLA 2020-05-12 08:11:19 EDT
(In reply to Andrey Loskutov from comment #8)
> Is this always reproducible on Windows? Comment 5?

I can see that it always happens when there is a vertical scrollbar in the inspect hover/popup. The presence of a horizontal scrollbar doesn't matter.
Comment 10 Alexandr Miloslavskiy CLA 2020-05-12 08:51:01 EDT
I wouldn't expect any issues from Bug 444560 when dark theme is not active.
Comment 11 Niraj Modi CLA 2020-05-12 13:17:34 EDT
(In reply to Alexandr Miloslavskiy from comment #10)
> I wouldn't expect any issues from Bug 444560 when dark theme is not active.

This issue got introduced in 4.16 M1 time-frame. Some results of the testing against the 4.16 M1 IBuilds I have locally:
- I cannot reproduce this issue with 4.16 M1 time-frame Eclipse Build id: I20200331-1800 which already had fix for SWT bug 444560.

- Then next 4.16 M1 I have locally is Eclipse Build id: I20200407-0120 on which problem is reproducible to me.

I cannot relate any SWT fix between these two Builds that could be directly responsible for this issue.

Moving this bug back to UI for further investigation.
Comment 12 Sarika Sinha CLA 2020-05-13 06:39:41 EDT
(In reply to Niraj Modi from comment #11)
> (In reply to Alexandr Miloslavskiy from comment #10)
> > I wouldn't expect any issues from Bug 444560 when dark theme is not active.
> 
> This issue got introduced in 4.16 M1 time-frame. Some results of the testing
> against the 4.16 M1 IBuilds I have locally:
> - I cannot reproduce this issue with 4.16 M1 time-frame Eclipse Build id:
> I20200331-1800 which already had fix for SWT bug 444560.
> 
> - Then next 4.16 M1 I have locally is Eclipse Build id: I20200407-0120 on
> which problem is reproducible to me.
> 
> I cannot relate any SWT fix between these two Builds that could be directly
> responsible for this issue.
> 
> Moving this bug back to UI for further investigation.

@Niraj, isn't it very similar to Bug 514288? Difference is now it is happening on light theme also.
I was able to consistently reproduce with I20200512-1800.
And there is no shadowing till the vertical scroll bar does not come, as soon as the vertical scroll bar comes, the text is re painted and looks like a shadow.
Comment 13 Niraj Modi CLA 2020-05-13 07:39:35 EDT
(In reply to Niraj Modi from comment #11)
> - Then next 4.16 M1 I have locally is Eclipse Build id: I20200407-0120 on
> which problem is reproducible to me.

Thanks to Lakshmi to pointing me to this bug 559434 fix in Platform UI, that went in with I20200407-0120.

Reverting the CSS fix by bug 559434, solves this issue.
Comment 14 Sarika Sinha CLA 2020-05-13 07:43:03 EDT
(In reply to Niraj Modi from comment #13)
> (In reply to Niraj Modi from comment #11)
> > - Then next 4.16 M1 I have locally is Eclipse Build id: I20200407-0120 on
> > which problem is reproducible to me.
> 
> Thanks to Lakshmi to pointing me to this bug 559434 fix in Platform UI, that
> went in with I20200407-0120.
> 
> Reverting the CSS fix by bug 559434, solves this issue.

Yes, reverting works for me as well.
Thanks Niraj and Lakshmi.
Comment 15 Gayan Perera CLA 2020-05-13 07:47:05 EDT
Does it fix for both light and dark themes as well ?
Comment 16 Sarika Sinha CLA 2020-05-13 08:18:30 EDT
(In reply to Gayan Perera from comment #15)
> Does it fix for both light and dark themes as well ?

For dark theme I don't see any issue apart from Bug 514288 which is for static things and this revert applies only to default theme.
Comment 17 Niraj Modi CLA 2020-05-13 08:33:24 EDT
(In reply to Sarika Sinha from comment #16)
> (In reply to Gayan Perera from comment #15)
> > Does it fix for both light and dark themes as well ?
It's only light theme.

Dark theme issue bug 514288 is caused by fix for bug 552938, for more details please see:https://bugs.eclipse.org/bugs/show_bug.cgi?id=514288#c22
Comment 18 Lars Vogel CLA 2020-05-13 11:06:22 EDT
(In reply to Niraj Modi from comment #17)

> Dark theme issue bug 514288 is caused by fix for bug 552938, for more
> details please see:https://bugs.eclipse.org/bugs/show_bug.cgi?id=514288#c22

I think the dark theme was fixed by Bug 562781 which removed the same CSS as bug 559434 for the light theme introduced. This whole custom drawing code on trees is planned to be removed via Bug 562865.
Comment 19 Niraj Modi CLA 2020-05-14 04:20:10 EDT
Since fix for bug 561896 also fixed this issue, closing as duplicate.

*** This bug has been marked as a duplicate of bug 561896 ***