Community
Participate
Working Groups
The editor content is frequently full with cheese if I activate code minings. I have not seen that in the last releases, maybe something changed recently? I know some performance improvements were done.
Eclipse SDK Version: 2021-03 (4.19) Build id: I20210208-1800 OS: Windows 10, v.10.0, x86_64 / win32 Java version: 15.0.1
Maybe a screenshot can help? I have no clue what kind of cheese you are referring to :-) There was a bug the has performed code-mining computation multiple times in a row, that might has hidden some glitches that are now more visible?
(In reply to Christoph Laeubrich from comment #2) > Maybe a screenshot can help? I have no clue what kind of cheese you are > referring to :-) As soon as I press "Take screnshot" in the windows screenshot tool the editor updates itself. I think it is scared of getting exposed. :-) I tried to make a screencast later.
Try [Prnt] / [Drucken] key instead and insert it into MS Paint afterwards from the clipboard.
I also see some issues, not sure they're the same ones though. The issues I see is that sometimes, the code mining text is printed over the actual line text. I think it would be relatively easy to put a guard in the drawing part to verify we draw only when the line height is properly set.
(In reply to Mickael Istria from comment #5) > I also see some issues, not sure they're the same ones though. > The issues I see is that sometimes, the code mining text is printed over the > actual line text. I think it would be relatively easy to put a guard in the > drawing part to verify we draw only when the line height is properly set. +1, yes the code mining text is printed over the actual line text.
What I have observed if there are really many minings and one scrolls fast it sometimes draws the minings over the text but that might be a different issue?
(In reply to Christoph Laeubrich from comment #7) > What I have observed if there are really many minings and one scrolls fast > it sometimes draws the minings over the text but that might be a different > issue? I don't scroll, I only edit and suddenly I get cheese.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/176155
This should be fixed now. Please reopen if you still see this problem in next I-Build.
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/176155 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=44937a86fdc04c57bac3c36229ac4e394988d096
Created attachment 285554 [details] Screencast Thanks Mickael, I can still see "cheese", I re-tested on Linux.
.
Moving to 4.20. Please re target as required.
Created attachment 285962 [details] Overlapped Rendering
Take the following example package app; import java.io.File; import java.nio.file.Paths; import java.util.Set; public class HelloTest { private File file; @org.junit.Test public void testHello() { Set<String> strings; this.file = new File(""); Paths } } Now make sure your imports are collapase, and then remove the "Paths" reference and organize imports. The source code rendering is not done properly to reflect the changes. This happens on when codeminings are available. I will attache a video which shows it in action
Created attachment 285963 [details] screencast_codemining_rendering
@Mickael let me know if you need more information or support in verifying fixes.
Can you please precise "The source code rendering is not done properly to reflect the changes" ? Without details, it's hard to know where to focus attention.
Created attachment 285964 [details] correctly rendered code
Created attachment 285965 [details] rendering issue 1 After organizing imports and moving your mouse this the first issue you can see
Created attachment 285966 [details] rendering issue 2 After moving your mouse and clicking on the editor, this happens.
@Gayan: those seem to be different issues as the one that triggered this bug report. Please open specific tickets for each issue.
*** Bug 572387 has been marked as a duplicate of this bug. ***
I don't know how the codeminings work internally to calculate the required spaces and so on but I recently came across a bug (it might be worth to try to make a repoducer) on windows where creating a temporary GC+painting on it under windows yields very strange results: The painted parts appear randomly on the screen, painting even on the title-bar and so on. Interestingly on some setups it help to switch off the second monitor while on my laptop it was evident always. So I wonder if the effect is visible on windows or also on linux/mac?
The Bug 572387 duplicate complains that a) Code Minings that may be useful for the *.target editor infect the Text and Generic Text Editors that should be more trustworthy. b) that the infection in the Text Editor is initially an overtype giving unreadable text in the screen shot but which clarifies after a redisplay separates the overtyped lines.
See Bug 572400 for demonstration of bad GC behavior under windows. I discovered this while I'm trying to measure text sizes "offscreen" so maybe Codeminings try to use similar and hit this bug also?
(In reply to Mickael Istria from comment #23) > @Gayan: those seem to be different issues as the one that triggered this bug > report. Please open specific tickets for each issue. Sure i will report a different bug with attachments. And this happens also when the file is small. Basically when the top of the file where your imports are no inside the view port.
new bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=573016
Mass move out of 4.20
Mass move out of 4.22
