Description Laurent Redor 2020-11-20 03:56:34 EST

IN ELK, for the label of ports, you can precise the location with "Port Label Placement" [1]. Two values are usefull: "INSIDE" or "OUTSIDE".
The result is like in ELK_insideOutsideSampleWithoutEdge.png (sometimes "NEXT_TO_PORT_IF_POSSIBLE" must be added to the previous values). With these values, the label is centered on the port, inside or outside of the node. This result is visible in ELK "Layout Graph" view with "insideOutsideSampleWithoutEdge.elkt"; or directly in ELK Demonstrators [2].

If an edge crosses the label, the label is automatically shifted to the corner, like in ELK_insideOutsideSampleWithEdge.png. This result is visible in ELK "Layout Graph" view with "insideOutsideSampleWithEdge.elkt"; or directly in ELK Demonstrators [3].

Unfortunately, the "corner location" is not a valid location in Sirius. So Sirius automatically uses an authorized location for the port label, not the same, and the result is often an overlap and/or a feeling of space too big, like in Sirius_insideOutsideSampleWithEdge.png. In the current version of Sirius, to avoid this kind of situation, the "Port Label Placement" is ignored and a fixed location is used. Code from org.eclipse.sirius.diagram.elk.ElkDiagramLayoutConnector.createPort(LayoutMapping, AbstractBorderItemEditPart, IGraphicalEditPart, ElkNode, Map<LayoutOptionTarget, Set<LayoutOption>>):
        // Set the location of port label fixed (indeed the location returned by ELK is currently not compatible with
        // Sirius constraint). The label is, by default, located centered below the port.
        elknode.setProperty(CoreOptions.PORT_LABELS_PLACEMENT, PortLabelPlacement.fixed());


This problem is linked to bug 550382 in Sirius 6.3.0. It has been reverted by bug 561385 in Sirius 6.3.1 as it has side effects.

The goals of this issue are:
* Implement fully the initial bug 550382 (by considering all aspects, a non exhaustive list is available in description of bug 561385)
* Verify that ELK "Port Label Placement" property [1], is correcty considered by Sirius: projet in "TestWithInsideOutsidePortLabel.zip" is a sample as starting point.

[1] https://www.eclipse.org/elk/reference/options/org-eclipse-elk-portLabels-placement.html
[2] https://rtsys.informatik.uni-kiel.de/elklive/elkgraph.html?compressedContent=PQKj4yunb+EgFAAIQoMIHsAOBPAJwEsBzACwBcUAKAYwEoUAmABlZQGkiBTAGxQCqAOyIA3bgQDORCnhQBDIQBMUWCmQmSAdKnS6UAFTJFJKHASwkC8gLYLlKddwW1aWGzkV4iQkihvyFBJE8rym8gTOAUrO8qLyRLzyAEa8zgCuyhKOGvpBBDamWABmOc4AorS8RDiSzgAK6alEtCgAMi3cQnXMWiwoAO7GtGQoJgrxiSlpChT6lBQ4AFzAwAPrWtxVNXVaWAQkwGkkocDcOLwAtEx9Omj6AMr1ACIAGpcdtF11lwCSMUIKERijwCEsUOV6m1rn1dIh4QjEUjwMAkFZ5DhRgBxACMSCSeCw6SoAG0UNIAF7ccEAZhYLAANMx6SgALpIIRYGIPIhUrRuboUaw+CiScEAIhJ9QA8gAlAwPJkAOWlz3KAH02gBBABC5TaipQMvlmt1+oerPFSFCJH2MjINnB+xIm22tW4m14AGstASJNwlEhjBIIiM8AAJRRKaq+cG-JUYNoCNXqjDh35tZ6y8pKjlYNryQnE8HFUJ1JB5mIoACyeCVXO4AHV7b9ukQqwBvJAASAJRNJPe7OCw0iBWCE4IA7IzmYPKdSUDiAGwzgCsLB77O7nO5vI9AskQoSgLFKElxoVytVGu1eoNTIvprvFqtQ-2FGwguFJ-BADFfq85TPOqDy-GqPbDgQFAFskfDaBc8hfDYXQUBKJLxqBaqWj2SSwfwbQ4hKtb1jEzbqK20gxOKKBdt2vaFv2KAkoOb6jkQ47gkwq5MquLHzuCOL0kyOKToOW7bg2MFwVoCFIShaHhqmOYGOUspMgAauqBjSvUTIYWB5TYd2AC+EHvkaOI0YOfbEkxLHDmxHGLquTDCRudHdvxzJMqwYmDs6rrVO6no+gAepBFBaMk+wxAQ0rFMUdSoSglwABywnR4XvlolELuUWoPAY1kpHw7SEWetblPIh4Ue23BSbw9TvtRtF0TZA4eaxMjsROKUACwzkweKdV5gkzjSS4seJpkmWZUFGkwVltQxtnMR5DndU5lw4q5i7uXRXmsD5+3iQFWxBbsfBhRFUUxRI8WJdwyVpRl3ZZVBOV1eCjblIVxV4WVRF4I23A1W2MQNU1UEtSx7V2Z1G1jr1lwDT5w0eaN67CaJHnTT2pmmZWzjEQ2ZFkNKxJ1UtcNrV1SNTjOY1znuAkrjx7lbju3A8nyB5HiKp7nnKl4oCqKa3uaD7C0+5pGRFn6Ht+op-gBQEgQZc3QSVYQyUkcmAmh0oCAqBnKuUrwGFp0rqo+vy-jb0oPKBOptIZr64aVBFAyRTb2hTop1TDy1Fh1dGIz1nHcSgvEYyzi6Cdjfl0VzDXwXr3DIQbZ4kopGDKapGlW7pKD6Vhr4zRFFlLfRIfw2HI6bb1OIuW5fFx0ds50adByBTsHpXVo72RdFBCxQ9SXgi9+1D59MTgvlf3LQDXsVXgVWHv7uWQ811c14xtP145yOo8w6MHXHY1MhNU2DjNFfmfUi2tTT9kN-TKU7a3sdUpxg0nf5Pdzp9xCoPG6I8x4JQnildK08bq5W+r9IqS9PblXFLWEGG9iRb21lDCgQdg77xYnTCO-VBpn08hfLGi4cZd1vvjJAhMgA
[3] https://rtsys.informatik.uni-kiel.de/elklive/elkgraph.html?compressedContent=PQKj4yunb+EgFAAIQoMIHsAOBPAJwEsBzACwBcUAKAYwEoUAmABlZQGkiBTAGxQCqAOyIA3bgQDORCnhQBDIQBMUWCmQmSAdKnS6UAFTJFJKHASwkC8gLYLlKddwW1aWGzkV4iQkihvyFBJE8rym8gTOAUrO8qLyRLzyAEa8zgCuyhKOGvpBBDamWABmOc4AorS8RDiSzgAK6alEtCgAMi3cQnXMWiwoAO7GtGQoJgrxiSlpChT6lBQ4AFzAwAPrWtxVNXVaWAQkwGkkocDcOLwAtEx9Omj6AMr1ACIAGpcdtF11lwCSMUIKERijwCEsUOV6m1rn1dIh4QjEUjwMAkFZ5DhRgBxACMSCSeCw6SoAG0UNIAF7ccFMAAcLAANCgAMwAFn6AF0kEIsDEHkQqVo3N0KNYfBRJOCAEQk+oAeQASgYHkyAHJy57lAD6bQAggAhcptFUoeVKnUGo0PDlSpChEj7GRkGzg-YkTbbWrcTa8ADWWgJEm4SiQxgkERGeAAEoolNVfODfqqMG0BJqtRgo782s8FeVVdysG15ITieDiqE6khCzEUABZPDYQEAdSdv26RFrAG8kABIAlE0l93s4LDSIFYITg9lM1jDynUlA4gDsjKXLBYfa5vZ5fIF3uFklFCUBkpQMrNyrVGu1esNxqZl4t9+ttpH+woTaPYtP4IAYr8rzlM8WoPL8mp9qOBAUMWyR8NoFzyF8NhdBQ0okkmYGajafZJHB-BtDi0oNk2FCtuo7bSDEUooD2vb9iWg4oCSw7vuORCTuCzIAKxMtxrELuCOIbkyK7DtuO68twsHwVoiHIah6FRhm+YGOUCpMgAalqBhyvUTKYeB5Q4b2AC+fa7s4DaqlJTC0cOA7EsxrGjuxnEoNxa7Mpu9G9oJKC0rxHk+b2El4Xw7RMMReA2TETA0XR9GOUOvlsTIHFTh5fGsX5+7gsuQVib5EmSTEMlhHJSQKYCSkqaqakaSg2m6fpKCGdhb5mX25nvtBpo4vZSWMU5LG+a56XuTiABsTCiSFuVUjSa5zvREluh61Rej6-oAHpQRQWjJPsMQEHKxTFHUaEoJctKwvRe0floVGLuUuoPAYDkpBFhHReU8hHpRnbSV9vD1B+CWsclzmpeNE6ZZcM7MHiqX+cJa5Fatw49T1+2mnZiVQ6N9Gwxl4KXDis3rgJeXMMtIVrQcG07N6fC7fth3HRIZ0XdwV03XdvYPdBT1A+CzblO9n34e0RHng2zbcADHZlSDYPQRDvmEzlJPuQjy3I75qOeaJy6sRJ2N9sGJAVLLJGTmRbbK961m2ddAB89aNvb5FkIDMRaPUA0E8NKX0XUtBwxCDwDUTYcUBEV3Gx5-GpV0SjgrSs7zRJ249VbFRRZ7pE+373r1HZlwe3bLaO89Wgu3Fg0MaWod+VskcS3Zsd+fH0FCTNWc5WnQk8XxKeYxP5nmTWVlezXFFO7qyhysSz2DVrxNjhNmWsCbIX+aw6OeVuFlSfygqHse4pnheipXig6rpneVqPnfz5WiZ+3lQhVXcChNXngwqqLCxk3zhQIoXKU1cHYL2ekvJQK8JRAw1s3JiscdaZRxJnDy1NFpLimqyE24lhyWW-pVJCf9FKAOUhgVS6ktI6T0gZYBRkTI4w-P1JuG9N5uUwQATkpquXBi5d602IfRdaWxNq7FZloIWB0joEBOtzS6ZNbohXAe0Zk0U1YwRBqXFBqCRray3nDMmiMmAGzDjTNGRDipY26qfWsDduBB0+i3aGPDt5LSZDxYRQkk5o3EaVbg58DyTm-CeCU6FLwmkfreS0D5TRv2fsaEyvU9H4R-hQ-+V0ZRygEMqVhnVNFtFZNFWKrjDHcK8WY5gQVx7WLwbYpcpt7G+VISDbJ1U8kkhoXQxqzUmFtRYR1Bxm8+qBybkY1uaU6k4lZJTPxKMaaiJWhPCRjMpHM22nI9mijlHnVUdddRkMQbtG4joj85VEHPUMTMzxY1TGk2usyPhWggqWJygtRcfC+F2PafRHqXUQX5whIXFxOIA4DUrpw4OHjY7hw7g8LuOUjwJyErSSm9Ih7KCEgIpkOLAW5yQNPIAA