Community
Participate
Working Groups
The goal of this bugzilla is to revert the feature that allows label located outside of a node, or border node, to be "everywhere" around the node (added in Sirius 6.1.4 with bug 549887 and in Sirius 6.3.0 with bug 550382). This feature must be reverted because it has side effects that are complex to manage. There is currently no time to handle them, so the decision is to revert the feature. As reminder, here is a non exhaustive list of "behaviors" to decide/check if this feature is handled in the future, in another issue: * Location of the label at the node creation (according to the "label alignment" value in the VSM) * Location of the label after an "arrange all" * Location of the label after a resize of the node; 2 cases: label shorter than the node, node shorter than the label * Location of the label after a rename (and so after a resize of the label); 2 cases: label shorter than the node, node shorter than the label * Location after the label has been manually moved (for all above cases) * Impact of "snap to grid" for all above cases * ...
New Gerrit change created: https://git.eclipse.org/r/160027
Gerrit change https://git.eclipse.org/r/160027 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=64fde6c649ef6eaff99c82f3609893e57ce9c524
Steps to validate: * Launch Sirius/Eclipse * Import project bug561385 (from bug561385.zip) * Open the diagram "diagramFreshlyCreated" * Expected --> the label "my.first.class" is centered on the top of the light blue node (like before) * Expected --> the label "my.first.attribute" is on the left of the dark blue border node (like before) * Move the label "my.first.class" to the left (but always on the top of the node) * Expected --> It is not possible (as the feature added in bug 550382 has been removed by this issue) * Move the label "my.first.attribute" to the bottom of the dark blue border node * Expected --> the label is automatically centered on the bottom of the dark blue border node and it is "dropped" where you want * Create a new class with the tool "New class" * Expected --> the class is created with a label "myNewClass" centered on the top of a new light blue node (like before) * Open the diagram "diagramWithMovedLabels" * Expected --> the label "my.first.class" is centered on the bottom of the light blue node (like before) * Expected --> the label "my.first.attribute" is on the bottom of the dark blue border node (like before) * Open the diagram "diagramWithMovedLabelsInSirius6.3.0" * Expected --> the label "my.first.class" is on the left on the bottom side of the light blue node (like before) * Expected --> the label "my.first.attribute" is on the bottom of the right side of the dark blue border node (like before)
Created attachment 282351 [details] bug561385.zip
When I tried to validate the scenario I had the following issues: - On "diagramFreshlyCreated", the label "my.first.attribute" was on the right side of the border node - On "diagramWithMovedLabels", the label where placed as expected - On "diagramWithMovedLabelsInSirius6.3.0", "my.first.class" was on the right on the bottom side of the light blue node and "my.first.attribute" is on the bottom of the left side of the dark blue border node (like before)
I reopened this bugzilla because of the previous comment.
(In reply to Steve Monnier from comment #5) > When I tried to validate the scenario I had the following issues: > - On "diagramFreshlyCreated", the label "my.first.attribute" was on the > right side of the border node > - On "diagramWithMovedLabels", the label where placed as expected > - On "diagramWithMovedLabelsInSirius6.3.0", "my.first.class" was on the > right on the bottom side of the light blue node and "my.first.attribute" is > on the bottom of the left side of the dark blue border node (like before) Oops, the steps to validate are wrong. You have the correct result. I'll post a new comment with the "valide" steps to validate.
Steps to validate (replace the comment 3): * Launch Sirius/Eclipse * Import project bug561385 (from bug561385.zip) * Open the diagram "diagramFreshlyCreated" * Expected --> the label "my.first.class" is centered on the top of the light blue node (like before) * Expected --> the label "my.first.attribute" is on the right of the dark blue border node (like before) * Move the label "my.first.class" to the left (but always on the top of the node) * Expected --> It is not possible (as the feature added in bug 550382 has been removed by this issue) * Move the label "my.first.attribute" to the bottom of the dark blue border node * Expected --> the label is automatically centered on the bottom of the dark blue border node and it is not "dropped" where you want * Create a new class with the tool "New class" * Expected --> the class is created with a label "myNewClass" centered on the top of a new light blue node (like before) * Open the diagram "diagramWithMovedLabels" * Expected --> the label "my.first.class" is centered on the bottom of the light blue node (like before) * Expected --> the label "my.first.attribute" is on the bottom of the dark blue border node (like before) * Open the diagram "diagramWithMovedLabelsInSirius6.3.0" * Expected --> the label "my.first.class" is on the right on the bottom side of the light blue node (like before but in the "bounds limit" of the node) * Expected --> the label "my.first.attribute" is on the bottom of the left side of the dark blue border node (like before)
I confirm that I was able to validate with the last scenario. This bugzilla can be set in verified state.
New Gerrit change created: https://git.eclipse.org/r/161471
Gerrit change https://git.eclipse.org/r/161471 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7c554ef06fea624b1bc442ff44b8140f0046e0e6
Available in Sirius 6.3.1 (part of Eclipse 2020-06). See https://wiki.eclipse.org/Sirius/6.3.1 for details on the release.
