550382 – Allow label located outside of a node, or border node, to be "everywhere" around the node

Bug 550382 - Allow label located outside of a node, or border node, to be "everywhere" around the node

Summary: Allow label located outside of a node, or border node, to be "everywhere" aro...

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Diagram (show other bugs)
Version:	6.1.3
Hardware:	PC All

Importance:	P3 enhancement (vote)
Target Milestone:	6.3.0
Assignee:	Laurent Redor
QA Contact:	Laurent Redor

URL:
Whiteboard:
Keywords:	triaged

Depends on:	549887
Blocks:
	Show dependency tree

Reported:	2019-08-23 09:06 EDT by Laurent Redor
Modified:	2020-11-20 04:24 EST (History)
CC List:	2 users (show)

See Also:	Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit Git Commit Git Commit Gerrit Change Gerrit Change Gerrit Change Gerrit Change Git Commit Git Commit 561385 568981

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Laurent Redor

2019-08-23 09:06:06 EDT

+++ This bug was initially created as a clone of Bug #549887 +++

Currently, when a user moves a label arround a node, especially if it is bigger than the node, some locations are skipped even if there is no real reason. For example, the label is always centered on north or south side when it is larger than the node.
As you can see on attached video, moveLabelOnBorder.webm, the label is always centered on north or south side.

Comment 1 Eclipse Genie

2019-08-23 10:05:15 EDT

New Gerrit change created: https://git.eclipse.org/r/148236

Comment 2 Eclipse Genie

2019-08-23 10:05:28 EDT

New Gerrit change created: https://git.eclipse.org/r/148238

Comment 3 Eclipse Genie

2019-08-23 10:05:31 EDT

New Gerrit change created: https://git.eclipse.org/r/148237

Comment 4 Eclipse Genie

2019-08-23 10:05:33 EDT

New Gerrit change created: https://git.eclipse.org/r/148239

Comment 5 Eclipse Genie

2019-08-23 11:42:50 EDT

Gerrit change https://git.eclipse.org/r/148237 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4185e3b16f15e075f71aa9fe1ea339bf6600913d

Comment 6 Eclipse Genie

2019-08-23 11:42:53 EDT

Gerrit change https://git.eclipse.org/r/148236 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c984936dc71785fb5a17ac59cf159d0ec8dfe67e

Comment 7 Eclipse Genie

2019-08-23 11:42:57 EDT

Gerrit change https://git.eclipse.org/r/148238 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=57b9deda512d2610bac72be2470fa4236f09fbf3

Comment 8 Eclipse Genie

2019-08-23 11:44:09 EDT

Gerrit change https://git.eclipse.org/r/148239 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=73f3a66dcecbe2bf47d8c5fc6ab5254c895c6548

Comment 9 Eclipse Genie

2019-08-26 04:55:32 EDT

New Gerrit change created: https://git.eclipse.org/r/148327

Comment 10 Eclipse Genie

2019-08-26 12:57:57 EDT

New Gerrit change created: https://git.eclipse.org/r/148360

Comment 11 Eclipse Genie

2019-08-27 04:00:20 EDT

New Gerrit change created: https://git.eclipse.org/r/148398

Comment 12 Eclipse Genie

2019-08-27 08:33:41 EDT

New Gerrit change created: https://git.eclipse.org/r/148439

Comment 13 Eclipse Genie

2019-08-27 08:37:57 EDT

Gerrit change https://git.eclipse.org/r/148439 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b6a413a546a3585fbe1ea70f88132db9bf32cc82

Comment 14 Eclipse Genie

2019-08-27 08:37:59 EDT

Gerrit change https://git.eclipse.org/r/148327 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=5bfd6ddd8c08ed6f39026a8bed8776dc1e4e87ef

Comment 15 Laurent Redor

2019-09-18 03:54:26 EDT

To validate, use the second part of scenario of the cloned bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=549887#c14 .
The first part no longer exists (the vm arg org.eclipse.sirius.experimental.labelOnBorderImprovement is only for the maintenance branch).

Comment 16 Laurent Redor

2019-10-02 12:15:32 EDT

Validated with ODCE 11.3.0 it2 (Sirius stable https://download.eclipse.org/sirius/updates/stable/6.3.0-S20190920-103515/2019-06/)

Comment 17 Pierre-Charles David

2019-12-09 02:56:05 EST

Available in Sirius 6.3.0, see https://wiki.eclipse.org/Sirius/6.3.0

Comment 18 Laurent Redor

2020-03-23 13:15:50 EDT

This feature has finally be reverted in Sirius 6.3.1 (see bug 561385 for more information).