Bug 566481 - Reduce error threshold value in UI freeze monitor
Summary: Reduce error threshold value in UI freeze monitor
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.14   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.18 M3   Edit
Assignee: Lars Vogel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 576902 566485
  Show dependency tree
 
Reported: 2020-08-28 05:40 EDT by Lars Vogel CLA
Modified: 2021-10-26 11:26 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2020-08-28 05:40:01 EDT 
Current value of 2000 seems relatively high for todays interactive performance. I suggest to reduce it to a lower value. Maybe 1200ms?
Comment 1 Eclipse Genie CLA 2020-08-28 05:40:55 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/168367
Comment 3 Sravan Kumar Lakkimsetti CLA 2020-12-04 00:19:25 EST 
This is causing spurious test failures bug 517227 comment 14. Can we have a property exposed such that we can either disable UI monitoring or tweak threshold?
Comment 4 Lars Vogel CLA 2020-12-04 04:33:55 EST 
(In reply to Sravan Kumar Lakkimsetti from comment #3)
> This is causing spurious test failures bug 517227 comment 14. Can we have a
> property exposed such that we can either disable UI monitoring or tweak
> threshold?

Hi Sravan, the setting is already a preference. IIRC preferences can be configured for unit tests. IIRC I have seen JDT doing that in their unit test.
Comment 5 Sravan Kumar Lakkimsetti CLA 2020-12-04 08:29:21 EST 
(In reply to Lars Vogel from comment #4)
> (In reply to Sravan Kumar Lakkimsetti from comment #3)
> > This is causing spurious test failures bug 517227 comment 14. Can we have a
> > property exposed such that we can either disable UI monitoring or tweak
> > threshold?
> 
> Hi Sravan, the setting is already a preference. IIRC preferences can be
> configured for unit tests. IIRC I have seen JDT doing that in their unit
> test.

Can you please let us know the preference name and how to use it?
Comment 6 Niraj Modi CLA 2020-12-07 04:10:46 EST 
Mass move out of 4.18
Comment 7 Lars Vogel CLA 2020-12-07 04:41:32 EST 
(In reply to Sravan Kumar Lakkimsetti from comment #5)
> Can you please let us know the preference name and how to use it?

Sorry, did miss that comment. You can use the preference spy for that purpose. Just install it (see https://www.vogella.com/tutorials/EclipseRCP/article.html#tutorial_installation_e4spies), open if via Ctrl+3 - Preference Spy, toogle the "Trace preferences" button and change the selected preference value. The spy will list the key and old and new value.
Comment 8 Lars Vogel CLA 2020-12-17 03:52:52 EST 
Please open a new bug for the preference setting in the tests.