Bug 517227 - [Tests] testVerboseStackTrace fails
Summary: [Tests] testVerboseStackTrace fails
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 4.7   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.19 M2   Edit
Assignee: Sarika Sinha CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 570000
Blocks:
  Show dependency tree
 
Reported: 2017-05-25 00:25 EDT by Sarika Sinha CLA
Modified: 2021-01-22 07:12 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sarika Sinha CLA 2017-05-25 00:25:04 EDT 
http://download.eclipse.org/eclipse/downloads/drops4/I20170524-0800/testresults/html/org.eclipse.ant.tests.ui_ep47I-unit-mac64_macosx.cocoa.x86_64_8.0.html

Console is not closed

junit.framework.AssertionFailedError: Console is not closed
at org.eclipse.ant.tests.ui.testplugin.AbstractAntUITest.launchAndWait(AbstractAntUITest.java:526)
at org.eclipse.ant.tests.ui.testplugin.AbstractAntUITest.launchAndTerminate(AbstractAntUITest.java:490)
at org.eclipse.ant.tests.ui.testplugin.AbstractAntUITest.launch(AbstractAntUITest.java:382)
at org.eclipse.ant.tests.ui.AbstractAntUIBuildTest.launch(AbstractAntUIBuildTest.java:106)
at org.eclipse.ant.tests.ui.BuildTests.testVerboseStackTrace(BuildTests.java:51)
at org.eclipse.ant.tests.ui.testplugin.AbstractAntUITest.runBare(AbstractAntUITest.java:129)
at org.eclipse.ant.tests.ui.AbstractAntUIBuildTest.access$0(AbstractAntUIBuildTest.java:1)
at org.eclipse.ant.tests.ui.AbstractAntUIBuildTest$1.run(AbstractAntUIBuildTest.java:44)
at java.lang.Thread.run(Thread.java:745)
Comment 3 Sarika Sinha CLA 2019-02-13 03:21:38 EST 
Previous error was -
testVerboseStackTrace fails as Console is not closed

A different error seen -
Incorrect message expected:<BUILD FAILED> but was:<null> 

Incorrect message expected:<BUILD FAILED> but was:<null> 

junit.framework.ComparisonFailure: Incorrect message expected:<BUILD FAILED> but was:<null>
at junit.framework.Assert.assertEquals(Assert.java:100)
at junit.framework.TestCase.assertEquals(TestCase.java:261)
at org.eclipse.ant.tests.ui.BuildTests.testVerboseStackTrace(BuildTests.java:55)

https://download.eclipse.org/eclipse/downloads/drops4/I20190212-1800/testresults/html/org.eclipse.ant.tests.ui_ep411I-unit-mac64-java8_macosx.cocoa.x86_64_8.0.html
Comment 9 Sarika Sinha CLA 2020-11-30 00:32:45 EST 
https://download.eclipse.org/eclipse/downloads/drops4/I20201128-1800/testresults/html/org.eclipse.ant.tests.ui_ep418I-unit-mac64-java11_macosx.cocoa.x86_64_11.html

!ENTRY org.eclipse.ui.monitoring 2 0 2020-11-28 16:48:16.771
!MESSAGE UI freeze of 0.63s at 16:48:16.140
!SUBENTRY 1 org.eclipse.ui.monitoring 1 0 2020-11-28 16:48:16.771
!MESSAGE Sample at 16:48:16.476 (+0.336s)
Thread 'main' tid=1 (RUNNABLE)
!STACK 0
Stack Trace
	at java.base@11.0.8/java.io.RandomAccessFile.readBytes(Native Method)
	at java.base@11.0.8/java.io.RandomAccessFile.read(RandomAccessFile.java:406)
	at java.base@11.0.8/java.io.RandomAccessFile.readFully(RandomAccessFile.java:470)
	at java.base@11.0.8/java.util.zip.ZipFile$Source.readFullyAt(ZipFile.java:1304)
	at java.base@11.0.8/java.util.zip.ZipFile$ZipFileInputStream.initDataOffset(ZipFile.java:998)
	at java.base@11.0.8/java.util.zip.ZipFile$ZipFileInputStream.read(ZipFile.java:1013)
	at java.base@11.0.8/java.util.zip.ZipFile$ZipFileInflaterInputStream.fill(ZipFile.java:468)
	at java.base@11.0.8/java.util.zip.InflaterInputStream.read(InflaterInputStream.java:159)
	at java.base@11.0.8/java.io.FilterInputStream.read(FilterInputStream.java:133)
	at org.eclipse.osgi.storage.bundlefile.CloseableBundleFile$BundleEntryInputStream.read(CloseableBundleFile.java:524)
	at java.base@11.0.8/java.io.FilterInputStream.read(FilterInputStream.java:107)
	at org.eclipse.osgi.storage.bundlefile.CloseableBundleFile$BundleEntryInputStream.read(CloseableBundleFile.java:533)
	at java.base@11.0.8/java.util.Properties$LineReader.readLine(Properties.java:499)
	at java.base@11.0.8/java.util.Properties.load0(Properties.java:415)
	at java.base@11.0.8/java.util.Properties.load(Properties.java:404)
	at org.eclipse.osgi.util.NLS.load(NLS.java:337)
	at org.eclipse.osgi.util.NLS.initializeMessages(NLS.java:152)
	at org.eclipse.ant.internal.ui.AntUIModelMessages.<clinit>(AntUIModelMessages.java:28)
Comment 10 Sarika Sinha CLA 2020-11-30 00:34:04 EST 
@Sravan,
Any idea why do we have so many freeze happening?
And can we disable UI Monitoring, as we read the Console and get the message based on line number these unexpected messages hamper the tests.
Comment 11 Sravan Kumar Lakkimsetti CLA 2020-11-30 01:32:55 EST 
(In reply to Sarika Sinha from comment #10)
> @Sravan,
> Any idea why do we have so many freeze happening?
> And can we disable UI Monitoring, as we read the Console and get the message
> based on line number these unexpected messages hamper the tests.

Looking at the log https://download.eclipse.org/eclipse/downloads/drops4/I20201128-1800/testresults/ep418I-unit-mac64-java11_macosx.cocoa.x86_64_11/org.eclipse.ant.tests.ui.testplugin.AntUITests.txt 
I find there are 5 freeze reports. 3 related to image creation and 2 for reading from zip file. the above indicates freeze happens when we are reading from the disk. 
Also since we are not seeing freeze with all images I feel the freeze threshold is a bit low.

From testing point of view we need to modify threshold programmatically. I am not sure this is possible. Other way is to remove ui monitoring plugin while running the tests. Not sure this is a viable option.
Comment 12 Sravan Kumar Lakkimsetti CLA 2020-11-30 01:34:45 EST 
(In reply to Sravan Kumar Lakkimsetti from comment #11)
> (In reply to Sarika Sinha from comment #10)
> > @Sravan,
> > Any idea why do we have so many freeze happening?
> > And can we disable UI Monitoring, as we read the Console and get the message
> > based on line number these unexpected messages hamper the tests.
> 
> Looking at the log
> https://download.eclipse.org/eclipse/downloads/drops4/I20201128-1800/
> testresults/ep418I-unit-mac64-java11_macosx.cocoa.x86_64_11/org.eclipse.ant.
> tests.ui.testplugin.AntUITests.txt 
> I find there are 5 freeze reports. 3 related to image creation and 2 for
> reading from zip file. the above indicates freeze happens when we are
> reading from the disk. 
> Also since we are not seeing freeze with all images I feel the freeze
> threshold is a bit low.
> 
> From testing point of view we need to modify threshold programmatically. I
> am not sure this is possible. Other way is to remove ui monitoring plugin
> while running the tests. Not sure this is a viable option.

We can remove UI monitoring plugin when we run ant ui tests(this will require modification to text.xml in aggregator project). But not sure that is the correct way to do it.
Comment 13 Sarika Sinha CLA 2020-11-30 23:39:20 EST 
(In reply to Sravan Kumar Lakkimsetti from comment #12)

> > 
> > From testing point of view we need to modify threshold programmatically. I
> > am not sure this is possible. Other way is to remove ui monitoring plugin
> > while running the tests. Not sure this is a viable option.
> 
> We can remove UI monitoring plugin when we run ant ui tests(this will
> require modification to text.xml in aggregator project). But not sure that
> is the correct way to do it.

can we check with anyone if it is OK/correct to do it?
Comment 14 Andrey Loskutov CLA 2020-12-03 02:33:42 EST 
(In reply to Sarika Sinha from comment #10)
> @Sravan,
> Any idea why do we have so many freeze happening?

Delay was made smaller in bug 566481.

> And can we disable UI Monitoring, as we read the Console and get the message
> based on line number these unexpected messages hamper the tests.

Yes, for sure, that should be disabled or timeout increased to some minutes for tests, otherwise it kicks in at most unexpected times.
Comment 15 Sarika Sinha CLA 2020-12-03 05:40:38 EST 
https://download.eclipse.org/eclipse/downloads/drops4/I20201202-1800/testresults/html/org.eclipse.ant.tests.ui_ep418I-unit-mac64-java11_macosx.cocoa.x86_64_11.html

@Sravan,
Can we increase the timeout to a minute as 1200ms for tests are not required.
Comment 16 Sravan Kumar Lakkimsetti CLA 2020-12-03 06:09:34 EST 
(In reply to Sarika Sinha from comment #15)
> https://download.eclipse.org/eclipse/downloads/drops4/I20201202-1800/
> testresults/html/org.eclipse.ant.tests.ui_ep418I-unit-mac64-java11_macosx.
> cocoa.x86_64_11.html
> 
> @Sravan,
> Can we increase the timeout to a minute as 1200ms for tests are not required.

If there is a way to increase this timeout via command-line, we can incorporate this into tests. Need to find out how to do it.
Comment 17 Sravan Kumar Lakkimsetti CLA 2020-12-04 00:20:11 EST 
(In reply to Sravan Kumar Lakkimsetti from comment #16)
> (In reply to Sarika Sinha from comment #15)
> > https://download.eclipse.org/eclipse/downloads/drops4/I20201202-1800/
> > testresults/html/org.eclipse.ant.tests.ui_ep418I-unit-mac64-java11_macosx.
> > cocoa.x86_64_11.html
> > 
> > @Sravan,
> > Can we increase the timeout to a minute as 1200ms for tests are not required.
> 
> If there is a way to increase this timeout via command-line, we can
> incorporate this into tests. Need to find out how to do it.

updated bug 566481 to get a property to tweak this value
Comment 28 Eclipse Genie CLA 2021-01-06 07:10:01 EST 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform/+/174324
Comment 30 Sarika Sinha CLA 2021-01-22 07:12:00 EST 
https://download.eclipse.org/eclipse/downloads/drops4/I20210121-2140/testResults.php

Not failing since many days.