Bug 566192 - Keybinding conflict with Clear Console command
Summary: Keybinding conflict with Clear Console command
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 4.17   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.17 M3   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-08-19 08:26 EDT by Andrey Loskutov CLA
Modified: 2020-08-20 03:46 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2020-08-19 08:26:18 EDT 
I saw following error in the log (no idea how to reproduce):

eclipse.buildId=4.17.0.I20200816-1800
java.version=11.0.8
java.vendor=N/A
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
Command-line arguments:  -os linux -ws gtk -arch x86_64

!ENTRY org.eclipse.jface 2 0 2020-08-19 10:48:33.931
!MESSAGE Keybinding conflicts occurred.  They may interfere with normal accelerator operation.
!SUBENTRY 1 org.eclipse.jface 2 0 2020-08-19 10:48:33.931
!MESSAGE A conflict occurred for CTRL+L:
Binding(CTRL+L,
	ParameterizedCommand(Command(org.eclipse.debug.ui.commands.console.clear,Clear Console,
		Clear Console,
		Category(org.eclipse.debug.ui.category.run,Run/Debug,Run/Debug command category,true),
		org.eclipse.ui.internal.WorkbenchHandlerServiceHandler@2592009c,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.console.ConsoleView,,,system)
Binding(CTRL+L,
	ParameterizedCommand(Command(org.eclipse.ui.edit.text.goto.line,Go to Line,
		Go to a specified line of text,
		Category(org.eclipse.ui.category.navigate,Navigate,null,true),
		org.eclipse.ui.internal.WorkbenchHandlerServiceHandler@4d96b968,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.textEditorScope,,,system)

Must be a regression from bug 81461.
Comment 1 Andrey Loskutov CLA 2020-08-19 08:27:21 EDT 
Paul, could you please check?
Comment 2 Andrey Loskutov CLA 2020-08-19 08:33:57 EDT 
Note: I saw this two times now, first time on 4.17.0.I20200816-1800 build, never before. 

Not sure if something else is changed in platform, because if the trigger would be the change for bug 81461 I would assume the I would see the conflict earlier in M1 already?

Just got it again. 

Steps to reproduce:
1) Start Eclipse, open text editor.
2) Open Console.
3) In the console, open new Java stack trace console.
4) Kaboom.
Comment 3 Andrey Loskutov CLA 2020-08-19 08:48:43 EDT 
I see it already in SDK-I20200713-2230, so it is really nothing new and is a direct effect of bug 81461.

Also I was unable to actually *use* Ctrl + L shortcut in the Java stack trace console, and I was only able to use it *once* in a process output console of a simple Java program - next time executing same shortcut on next run of same program didn't work.

@Paul: I would propose to remove shortcut definition for M3 and reopen bug 81461.

I believe this could be related to the console focus issues (I remember we had some bugs saying that the console doesn't properly manage focus).
Comment 4 Eclipse Genie CLA 2020-08-19 09:05:58 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.debug/+/167950
Comment 6 Paul Pazderski CLA 2020-08-19 15:21:37 EDT 
(In reply to Andrey Loskutov from comment #3)
> @Paul: I would propose to remove shortcut definition for M3 and reopen bug
> 81461.

Ok for me. The default binding wasn't requested in bug 81461. I was aware of the 'Go to line' binding but expected it to work due to the different contexts.
Comment 7 Andrey Loskutov CLA 2020-08-20 03:46:41 EDT 
Verified with I20200819-1800