Community
Participate
Working Groups
Currently, the CTabRendering forces that the background of the Tab element *content* is derived from the tab color. This can be (and often is) undesired for themes that want to highlight the tab with some color without willing to change the "lines" color. We should add to theming a way to instruct whether to propagate tab colors to tab contents or not.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167476
I wonder how this relates to Bug 546987, it might be fixed by these changes or it might affect this change too.
(In reply to Rolf Theunissen from comment #2) > I wonder how this relates to Bug 546987, it might be fixed by these changes > or it might affect this change too. I think the proposed change would basically make bug 546987 not surface, unless the ctabfolder is explicitly requested to inherit the tab color to children composites (eg toolbar)
+1 for fixing this, it's caused me some troubling workarounds downstream: https://github.com/AObuchow/Eclipse-Spectrum-Theme/issues/36
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167476 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3a36645ba15be9300cec478904018137f51eaccb
Created attachment 283828 [details] Screenshot In its current state, the view toolbar looks like is belongs to the non-active part see screenshot. I know you are planning more changes in this area but this change alone does IMHO not look good.
Please add to N&N
These changes has broken light theme on Linux.
(In reply to Amit Mendapara from comment #8) > These changes has broken light theme on Linux. Sorry, not these changes. The light theme is broken though, I will check further.
I can confirm. These changes has partly broken the light theme on Linux.
(In reply to Amit Mendapara from comment #10) > I can confirm. These changes has partly broken the light theme on Linux. What is broken? What is the problem you observe?
As Lars mentioned in a previous comment, there is an issue with toolbar background and unselected tab text color is became unreadable.
I'm going to change the outline to a white line, so it will be a bit clearer that the content of the view belongs to the active tab.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167776
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167776 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b35d6ef53e51908f32af678c3c1a0992221f73ff
I am still seeing the issues. Also, the last commit introduced another issue when you hover on an unselected tab. I just tried reverting these two commits: 3a36645ba15be9300cec478904018137f51eaccb b35d6ef53e51908f32af678c3c1a0992221f73ff and everything was fine. I think these changes should be reverted and should be reworked in 4.18.
All that said, I'll probably change the current theme so that it takes advantage of the new "swt-draw-custom-tab-content-background: true;" to just restore the old behavior. For the other patches I've linked, I'll basically start a new theme anyway.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167809
I've basically restored the current light theme to its current form, taking advantage of the new setting to force propagation of the tab color as content background and restoring the workaround for toolbar color in the CSS. Further work will happen in a separate theme.
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167809 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b6aeb4039efbd963dfcb81f688986045941c129a
(In reply to Mickael Istria from comment #19) > I've basically restored the current light theme to its current form, taking > advantage of the new setting to force propagation of the tab color as > content background and restoring the workaround for toolbar color in the CSS. > Further work will happen in a separate theme. Can you also run a test with '-cssTheme none' as program argument? To check that the current state is desirable.
(In reply to Mickael Istria from comment #19) > I've basically restored the current light theme to its current form, taking > advantage of the new setting to force propagation of the tab color as > content background and restoring the workaround for toolbar color in the CSS. > Further work will happen in a separate theme. Just tested the latest changes. Now it's working fine. However, gerrit https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167776 should be reverted.
(In reply to Amit Mendapara from comment #22) > Just tested the latest changes. Now it's working fine. However, gerrit > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167776 should be > reverted. It won't be fully reverted as it's useful for some other thmes. However, if you identify some specific bugs in this patch, those can be fixed.
(In reply to Mickael Istria from comment #23) > (In reply to Amit Mendapara from comment #22) > > Just tested the latest changes. Now it's working fine. However, gerrit > > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167776 should be > > reverted. > > It won't be fully reverted as it's useful for some other thmes. > However, if you identify some specific bugs in this patch, those can be > fixed. Sorry, it was https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167776.
My bad. It was same. BTW, the these changes https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167776/1/bundles/org.eclipse.ui.themes/css/e4_default_gtk.css should be reverted.
(In reply to Amit Mendapara from comment #25) > My bad. It was same. > > BTW, the these changes > https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167776/1/bundles/ > org.eclipse.ui.themes/css/e4_default_gtk.css should be reverted. Can you please share some before/after screenshots to explain what is degraded?
Created attachment 283884 [details] before.gif
Created attachment 283885 [details] after.gif
Check the before and after gif. You can see the tabs have no separator borders when we mouse over an unselected tab.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167846
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/167846 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=040fbda9883f9199dfd844582eeb063603a8d353
Several third-party themes are now rendering incorrectly because of these changes (e.g. Spectrum theme and Planet themes), as the default behaviour of CTabRendering has changed with commit 3a36645ba15be9300cec478904018137f51eaccb. Could the new "swt-draw-custom-tab-content-background" CSS property please be documented in the N&N? It would have saved me a fair bit of debugging and investigation to narrow down to this commit. :)
