Community
Participate
Working Groups
Created attachment 283491 [details] Screen Recording After switching to dark mode in my runtime workspace and restart, a white line is shown behind toolbar items. It is even moving when the window is resized. See attached screen recording.
Hi Karsten, I have 4.17 integration build I20200704-0600 on my Mac (Catalina 10.15.5; Java 14.0.1) and I cannot reproduce your problem with the Outline view's toolbar as shown in your attached gif. Maybe, your problem had been fixed, meanwhile. Can anyone confirm and add a link to the corresponding ticket?
The number of bugs from CTabFolder toolbar CSS really points to a fundamental API/Contract problem. Myself and others have tried so many band-aid fixes. Maybe the Eclipse team and SWT team should come together on this topic and come up with a fool proof plan. All my investigations into this have proven that there is conflict between the CSS and the standard SWT calls for setForeground and setBackground calls.
(In reply to Mike Marchand from comment #2) > The number of bugs from CTabFolder toolbar CSS really points to a > fundamental API/Contract problem. Myself and others have tried so many > band-aid fixes. Maybe the Eclipse team and SWT team should come together on > this topic and come up with a fool proof plan. +1
Unable to reproduce on Linux. So it should be macOS specific only. IMO, swt should support transparent background via CSS to solve many of such issues. I can see many components in eclipse with lots of nested swt widgets. For example, toolbars in CTabFolder.
*** Bug 566212 has been marked as a duplicate of this bug. ***
Moving to SWT as I cannot reproduce this on Linux and Win.
*** Bug 567613 has been marked as a duplicate of this bug. ***
Can someone please suggest which css files should I look into to investigate this issue? Any ideas on where the white line is coming from will be very helpful.
*** Bug 567127 has been marked as a duplicate of this bug. ***
(In reply to Lakshmi P Shanmugam from comment #8) > Can someone please suggest which css files should I look into to investigate > this issue? Any ideas on where the white line is coming from will be very > helpful. @Lars, can you please help here?
(In reply to Lakshmi P Shanmugam from comment #10) > (In reply to Lakshmi P Shanmugam from comment #8) > > Can someone please suggest which css files should I look into to investigate > > this issue? Any ideas on where the white line is coming from will be very > > helpful. > @Lars, can you please help here? I don't see the white line neither on Linux nor Windows so I don't think it comes in general from the CSS files. If you remove the plugin.xml restriction for the dark theme from Linux (oss) and switch to the dark theme from Linux on Mac do you also see the white line?
(In reply to Lars Vogel from comment #11) > (In reply to Lakshmi P Shanmugam from comment #10) > > (In reply to Lakshmi P Shanmugam from comment #8) > > > Can someone please suggest which css files should I look into to investigate > > > this issue? Any ideas on where the white line is coming from will be very > > > helpful. > > @Lars, can you please help here? > > I don't see the white line neither on Linux nor Windows so I don't think it > comes in general from the CSS files. If you remove the plugin.xml > restriction for the dark theme from Linux (oss) and switch to the dark theme > from Linux on Mac do you also see the white line? Thanks Lars. I tested with different themes. The problem seems related to theming, it doesn't happen when Eclipse theming is disabled. Happens with Dark and System theme, doesn't happen with Light and Classic theme on Mac. Happens when I use linux dark theme css on Mac too.
(In reply to Lakshmi P Shanmugam from comment #12) > Thanks Lars. > I tested with different themes. The problem seems related to theming, it > doesn't happen when Eclipse theming is disabled. If theming is disabled, no color call happens on the toolbar and related composites, so I assume we are seeing a SWT bug here triggered by one of the color calls in the theme. The CSS engine only calls setBackground / Foreground etc on the widget. > Happens with Dark and System theme, doesn't happen with Light and Classic > theme on Mac. Happens when I use linux dark theme css on Mac too. Does it happen in the SWT test view if you set the background / foreground color of the toolbar / toolbar container? You could also try the PDE "Layout spy" via Ctrl+3 which colors the container elements randomly.
*** Bug 565920 has been marked as a duplicate of this bug. ***
Created attachment 284801 [details] swt-unselected-tabs-color without gradient color (In reply to Lars Vogel from comment #13) > (In reply to Lakshmi P Shanmugam from comment #12) > > Thanks Lars. > > I tested with different themes. The problem seems related to theming, it > > doesn't happen when Eclipse theming is disabled. > > If theming is disabled, no color call happens on the toolbar and related > composites, so I assume we are seeing a SWT bug here triggered by one of the > color calls in the theme. The CSS engine only calls setBackground / > Foreground etc on the widget. > > > > Happens with Dark and System theme, doesn't happen with Light and Classic > > theme on Mac. Happens when I use linux dark theme css on Mac too. > > Does it happen in the SWT test view if you set the background / foreground > color of the toolbar / toolbar container? > > You could also try the PDE "Layout spy" via Ctrl+3 which colors the > container elements randomly. Thanks Lars. This seems to be caused by setting the gradient background for CTabfolder. In org.eclipse.ui.themes/css/dark/e4-dark_tabstyle.css, line 35, when I remove the gradient background color in swt-unselected-tabs-color, the white line doesn't appear. I changed: swt-unselected-tabs-color: '#org-eclipse-ui-workbench-ACTIVE_UNSELECTED_TABS_COLOR_START' '#org-eclipse-ui-workbench-ACTIVE_UNSELECTED_TABS_COLOR_END' 100% 100%; to swt-unselected-tabs-color: '#org-eclipse-ui-workbench-ACTIVE_UNSELECTED_TABS_COLOR_START' But, this causes all tabs to be drawn with same color and min/max are also different. Please see attached screenshot.
The white line is visible using the "Light" Mac theme as well as the "Dark" theme.
Adding Jeeeyul, as he is very experience in CSS styling and recently worked on SWT for the Mac. Jeeeyul, maybe you can help?
Created attachment 284844 [details] Screen shot of Light Theme toolbar (In reply to Phil Beauvoir from comment #16) > The white line is visible using the "Light" Mac theme as well as the "Dark" > theme. It's not always visible - resizing the sash from left to right will trigger it.
Created attachment 284845 [details] Screen shot of System Theme toolbar Also present in the new "System" theme.
Created attachment 284854 [details] screenshot of toolbar in ubuntu 20 I am tying to debug this issue, I noticed there is definite problem in the drawing of background for ToolBar(all platforms). If you zoom in attached screenshot you can make out border for the ToolBar. In case of Mac the drawing location is not correct. There is a 1 point size difference in ToolBar and its parent ToolBarComposite. I don't have any conclusions yet. I noticed the css definition for ToolBar and ToolBarComposite as "inherit". That means the color is getting inherited from a previous layer I am still investigating
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/172731
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/172731 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4f5f2dca6656f039d2c3b2fb58d44aa8302bcf20
Merged to master
Merged to master and system theme problems are being handled through bug 567631
(In reply to Sravan Kumar Lakkimsetti from comment #24) > Merged to master and system theme problems are being handled through bug > 567631 Thanks for fixing this one.
Thanks for the fix. I no longer see the white line on the Light and Dark themes. I still see the white line on the System theme, I guess this is related to bug 567631?
Created attachment 284881 [details] Screen shot of Light Theme toolbar on latest I build Actually, I am mistaken. With the latest I-build I am still seeing the white banding on the gradient in the toolbar as before. If I put the focus on the tree in the package explorer then move the Sash from left to right the toolbar icons are rendered as in the screenshot.
(In reply to Phil Beauvoir from comment #27) > Created attachment 284881 [details] > Screen shot of Light Theme toolbar on latest I build > > Actually, I am mistaken. > > With the latest I-build I am still seeing the white banding on the gradient > in the toolbar as before. > > If I put the focus on the tree in the package explorer then move the Sash > from left to right the toolbar icons are rendered as in the screenshot. Raised bug 569168 for the gradient separator line issue.
*** Bug 569179 has been marked as a duplicate of this bug. ***
Verified in I20201125-1800. With this fix, the white line in the toolbar is no longer seen in the dark theme. But, it's still seen in the System theme and a gradient is slightly visible in the dark theme too, tracked by bug 569168. Light theme didn't have this problem since Bug 566842 was fixed, there is no gradient colours in the toolbar.
(In reply to Lakshmi P Shanmugam from comment #30) > Verified in I20201125-1800. > With this fix, the white line in the toolbar is no longer seen in the dark > theme. > > But, it's still seen in the System theme and a gradient is slightly visible > in the dark theme too, tracked by bug 569168. > > Light theme didn't have this problem since Bug 566842 was fixed, there is no > gradient colours in the toolbar. Maybe we should remove the gradient from dark theme too?
(In reply to Lars Vogel from comment #31) > (In reply to Lakshmi P Shanmugam from comment #30) > > Verified in I20201125-1800. > > With this fix, the white line in the toolbar is no longer seen in the dark > > theme. > > > > But, it's still seen in the System theme and a gradient is slightly visible > > in the dark theme too, tracked by bug 569168. > > > > Light theme didn't have this problem since Bug 566842 was fixed, there is no > > gradient colours in the toolbar. > > Maybe we should remove the gradient from dark theme too? Yes, if we can remove the gradient from dark theme and system theme, we will not see this problem in Eclipse. I mentioned in #comment15, I tried to modify the line that sets the gradient, but it lead to other issues, so I guess more changes are required.
(In reply to Lakshmi P Shanmugam from comment #32) > I mentioned in #comment15, I tried to modify the line that sets the > gradient, but it lead to other issues, so I guess more changes are required. Lets investigate the gradient removal for 4.19.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/176296
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/176296 was merged to [R4_15_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=c4e641d3b3fe57b80004fe234deadfe5c3f58491
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183783
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183783 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=0d047808caf4c74b8ffd1e6dca8fc2d4fd2a4627
