Bug 563958 - Navigation shortcuts no longer works
Summary: Navigation shortcuts no longer works
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.15   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks: 552208
  Show dependency tree
 
Reported: 2020-06-04 15:52 EDT by Thiago Berne CLA
Modified: 2022-03-25 12:16 EDT (History)
5 users (show)

See Also:


Attachments
Log (3.32 KB, application/octet-stream)
2020-06-09 17:27 EDT, Thiago Berne CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Berne CLA 2020-06-04 15:52:33 EDT
Navigation shortcuts (alt + left/right on Windows) no longer works. I'm aware of bug 150087 but I decided to open a new one because that one affects Mac and I'm on Windows.

If using the toolbar buttons, navigation works properly.

Bug demonstration / installed plugins: https://youtu.be/hiPar48kRWM
Comment 1 Andrey Loskutov CLA 2020-06-06 05:50:21 EDT
Can't reproduce with 4.16 RC2. Any errors in the log? How did you get into this state?
Comment 2 Thiago Berne CLA 2020-06-09 17:04:16 EDT
(In reply to Andrey Loskutov from comment #1)
> Can't reproduce with 4.16 RC2. Any errors in the log? How did you get into
> this state?

Clearing the error log and performing the Alt + Left hotkey, nothing shows on error log. Before clearing, some erros occurred. If needed, I can post them.

To get into this state, I basically open and start using Eclipse (I don't know if I usually do something that breaks something, though).
Comment 3 Thiago Berne CLA 2020-06-09 17:27:00 EDT
Created attachment 283209 [details]
Log
Comment 4 Thiago Berne CLA 2020-06-09 17:34:12 EDT
The following log entry calls my attention:

!ENTRY org.eclipse.jface 2 0 2020-06-09 18:19:27.184
!MESSAGE Keybinding conflicts occurred.  They may interfere with normal accelerator operation.
!SUBENTRY 1 org.eclipse.jface 2 0 2020-06-09 18:19:27.184
!MESSAGE A conflict occurred for CTRL+SHIFT+V:
Binding(CTRL+SHIFT+V,
	ParameterizedCommand(Command(org.jkiss.dbeaver.core.edit.paste.special,Colar Avançado,
		Colar com configurações especiais,
		Category(org.jkiss.dbeaver.core.util,Utilitário,Utilitário de comando,true),
		org.eclipse.ui.internal.WorkbenchHandlerServiceHandler@3c0becae,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,,system)
Binding(CTRL+SHIFT+V,
	ParameterizedCommand(Command(org.eclipse.jdt.debug.ui.command.OpenFromClipboard,Open from Clipboard,
		Opens a Java element or a Java stack trace from clipboard,
		Category(org.eclipse.ui.category.navigate,Navigate,null,true),
		org.eclipse.ui.internal.WorkbenchHandlerServiceHandler@373c367,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,,system)
!SUBENTRY 1 org.eclipse.jface 2 0 2020-06-09 18:19:27.184
!MESSAGE A conflict occurred for CTRL+SHIFT+A:
Binding(CTRL+SHIFT+A,
	ParameterizedCommand(Command(org.jkiss.dbeaver.core.navigator.set.default,Definir com padrão,
		Definir como objeto padrão,
		Category(org.jkiss.dbeaver.core.navigator,Navegador de Banco de Dados,Comandos do Navegador de Banco de Dados,true),
		org.eclipse.ui.internal.WorkbenchHandlerServiceHandler@79690a0a,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,,system)
Binding(CTRL+SHIFT+A,
	ParameterizedCommand(Command(org.eclipse.pde.ui.openPluginArtifact,Open Plug-in Artifact,
		Open a plug-in artifact in the manifest editor,
		Category(org.eclipse.ui.category.navigate,Navigate,null,true),
		org.eclipse.ui.internal.WorkbenchHandlerServiceHandler@619944a7,
		,,true),null),
	org.eclipse.ui.defaultAcceleratorConfiguration,
	org.eclipse.ui.contexts.window,,,system)


After I saw that, I removed CTRL+SHIFT+(A|V) mappings and restarted Eclipse. The error log (as expected) disappeared. But ALT+LEFT still doesn't work.
Comment 5 Thiago Berne CLA 2020-06-09 18:12:35 EDT
The bug happening: https://youtu.be/yl9xYTs-2BQ
Please, note that when I use tool bar buttons, the navigation works properly.
Comment 6 Rolf Theunissen CLA 2020-06-11 03:01:11 EDT
I was able to reproduce it for a while, on a 4.17 I build. The keys don't work just after restart. It appeared to me that the navigation started working by keys after using the menu items, or after switching tabs. However, I could no longer investigate because it doesn't appear anymore.

Can you confirm that the keys start working after using the toolbar buttons or switching tabs?

Seems that there is a race condition somewhere.
Comment 7 Thiago Berne CLA 2020-06-12 10:02:35 EDT
(In reply to Rolf Theunissen from comment #6)
> I was able to reproduce it for a while, on a 4.17 I build. The keys don't
> work just after restart. It appeared to me that the navigation started
> working by keys after using the menu items, or after switching tabs.
> However, I could no longer investigate because it doesn't appear anymore.
> 
> Can you confirm that the keys start working after using the toolbar buttons
> or switching tabs?
> 
> Seems that there is a race condition somewhere.

It makes no difference. Still doesn't work.
Comment 8 Thiago Berne CLA 2020-06-18 09:48:35 EDT
One more information: if I go to keys configuration, remove and re-add the binding, the shortcut starts working (until the next Eclipse restart).
Comment 9 jfc jrtc CLA 2022-03-25 06:22:18 EDT
I have similar problems. I also use dbeaver plugin.

Now even the CTRL+F11 (run) shortcut doesn't work anymore.

I recognized, when I start eclipse without a dbeaver-data-view opened, the shortcuts are working.

But when I once display a dbeaver-data-view, after that, the shortcuts do not work anymore, even when I switch to a java-file-editor.

Is this an eclipse bug or a dbeaver bug?
Comment 10 jfc jrtc CLA 2022-03-25 06:23:45 EDT
I am using eclipse
Version: 2021-12 (4.22.0)
Build id: 20211202-1639
Comment 11 Rolf Theunissen CLA 2022-03-25 09:37:41 EDT
(In reply to jfc jrtc from comment #9)
> I have similar problems. I also use dbeaver plugin.
> 
> Now even the CTRL+F11 (run) shortcut doesn't work anymore.
> 
> I recognized, when I start eclipse without a dbeaver-data-view opened, the
> shortcuts are working.
> 
> But when I once display a dbeaver-data-view, after that, the shortcuts do
> not work anymore, even when I switch to a java-file-editor.
> 
> Is this an eclipse bug or a dbeaver bug?

DBeaver defines its own shortcuts bound to CTRL+F11, see [1]. So there is a conflict in bindings. Did this work on older versions? There might have been a change in priority of handlers.

[1] https://dbeaver.com/docs/wiki/Shortcuts/
Comment 12 jfc jrtc CLA 2022-03-25 09:51:04 EDT
Maybe it's a conflict, but then, at least, after switching to a java-editor, the window-wide shortcut should work.

I have also the same problems with alt+left/right shortcuts.

I think the CTRL-F11 problem is new, the other problem is since 1-2 years at least.
Comment 13 jfc jrtc CLA 2022-03-25 09:54:06 EDT
I now removed the other ctrl-f11 shortcut, and it works, so thanks for your hint about the dbeaver shortcut. Is there now a priority of handlers bug to be fixed?
Comment 14 Rolf Theunissen CLA 2022-03-25 12:02:12 EDT
(In reply to jfc jrtc from comment #13)
> I now removed the other ctrl-f11 shortcut, and it works, so thanks for your
> hint about the dbeaver shortcut. Is there now a priority of handlers bug to
> be fixed?

I expect that the ctrl-f11 regression is around since 4.16, this is a regression/stricter behavior in Eclipse see Bug 571513 Comment 6. But that is long ago also. If it is a recent regression, it could be caused by changes in DBeaver too. Probably this should be fixed in DBeaver.
What was the latest version that it did work?
Comment 15 Rolf Theunissen CLA 2022-03-25 12:16:25 EDT
(In reply to Rolf Theunissen from comment #14)
> (In reply to jfc jrtc from comment #13)
> > I now removed the other ctrl-f11 shortcut, and it works, so thanks for your
> > hint about the dbeaver shortcut. Is there now a priority of handlers bug to
> > be fixed?
> 
> I expect that the ctrl-f11 regression is around since 4.16, this is a
> regression/stricter behavior in Eclipse see Bug 571513 Comment 6. But that
> is long ago also. If it is a recent regression, it could be caused by
> changes in DBeaver too. Probably this should be fixed in DBeaver.
> What was the latest version that it did work?

DBeaver change/issue that should have fixed the conflict:
https://github.com/dbeaver/dbeaver/issues/10809