Bug 56380 - [DynamicUI] PerspectiveRegistry needs to be more resilient
Summary: [DynamicUI] PerspectiveRegistry needs to be more resilient
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M9   Edit
Assignee: Debbie Wilson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-26 11:58 EST by Debbie Wilson CLA
Modified: 2004-05-19 11:18 EDT (History)
3 users (show)

See Also:

Attachments
2.1 preference file (297.33 KB, application/octet-stream)
2004-03-26 11:59 EST, Debbie Wilson CLA 		no flags Details
Another log file (7.32 KB, text/plain)
2004-03-26 12:02 EST, Debbie Wilson CLA 		no flags Details
Another log file (4.43 KB, text/plain)
2004-03-26 12:02 EST, Debbie Wilson CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Debbie Wilson CLA 2004-03-26 11:58:18 EST 
This is in relation to the following bugs:
bug 56038 - NPEs and other errors loading custom perspective and
bug 56226 - 2.1 Preference file -> 3.0 workspace

I200403260800
- clean workspace
- Preferences->Import the attached file (from bug 56038) which is a 2.1 
preference file
- try to open the Debug perspective
You get a dialog called 'Restoring Problems' with the errors:
'Could not create view: org.eclipse.debug.ui.ConsoleView'
and 
'Could not find view: org.eclipse.debug.ui.ConsoleView'

The log file contains:

!MESSAGE Unable to find Action Set: org.eclipse.jdt.debug.ui.JDTLaunchActionSet

After this the PerspectiveRegistry appears to have been corrrupted.  In this 
particular instance, one of the descriptors is now null.  This will eventually 
cause an NPE.  I will attach other log files showing other areas where the 
registry is not robust enough.
Comment 1 Debbie Wilson CLA 2004-03-26 11:59:24 EST 
Created attachment 8919 [details]
2.1 preference file

The original preference file from bug 56038.
Comment 2 Debbie Wilson CLA 2004-03-26 12:02:13 EST 
Created attachment 8920 [details]
Another log file
Comment 3 Debbie Wilson CLA 2004-03-26 12:02:33 EST 
Created attachment 8921 [details]
Another log file
Comment 4 Debbie Wilson CLA 2004-03-26 12:05:32 EST 
Look at other UI registries to ensure their resilience as well.
Comment 5 Debbie Wilson CLA 2004-03-29 14:50:44 EST 
A counter in the RegistryManager (numObjects) was causing the grief.  In some 
cases, this counter got out of sync.  The counter and the need for it have 
been removed.  Available I20040330.