Bug 562529 - [Dark Theme] Some tabs in preference pages aren't styled
Summary: [Dark Theme] Some tabs in preference pages aren't styled
Status: CLOSED DUPLICATE of bug 508633
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.15   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 497562
  Show dependency tree
 
Reported: 2020-04-27 11:59 EDT by Pierre-Yves Bigourdan CLA
Modified: 2020-05-25 05:55 EDT (History)
2 users (show)

See Also:


Attachments
Tab headers from light theme in dark theme (51.26 KB, image/png)
2020-04-27 11:59 EDT, Pierre-Yves Bigourdan CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Yves Bigourdan CLA 2020-04-27 11:59:35 EDT
Created attachment 282578 [details]
Tab headers from light theme in dark theme

This issue happens at least on Windows, not sure about other operating systems.

In the dark theme, most tabs have a dark background and white text, for example in the editor area, the different views, etc.

For some tabs in Eclipse's preference pages, no styling is applied. This is visible for example in General -> Compare/Patch, General -> Security -> Secure Storage, and a few other places. The selected tab appears white with black text, and unselected tabs appear light grey with black text. See attachment for an example.

Can this be changed by CSS? I'm unable to use CSS Spy in the preferences window, am I missing something?
Comment 1 Mike Marchand CLA 2020-05-06 17:24:03 EDT
This is caused by using SWT TabFolder.  

In our Eclipse-based product, we have a custom proxy class to use TabFolder on light theme and CTabFolder on Dark theme (only on certain platforms IIRC, Windows is definitely one).
Comment 2 Lars Vogel CLA 2020-05-25 05:55:21 EDT

*** This bug has been marked as a duplicate of bug 508633 ***