Bug 560195 - [Win32] Remove runtime assembly manifest activation
Summary: [Win32] Remove runtime assembly manifest activation
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.15   Edit
Hardware: PC Windows All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Nikita Nemkin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-16 09:29 EST by Nikita Nemkin CLA
Modified: 2022-06-03 01:18 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Nemkin CLA 2020-02-16 09:29:36 EST 
Runtime assembly manifest activation is a very hacky workaround that isn't necessary anymore. Java executables (java.exe/javaw.exe) have correct manifests since at least Java 8.

Original code was added for bug 45918.
Comment 1 Eclipse Genie CLA 2020-02-16 09:33:21 EST 
New Gerrit change created: https://git.eclipse.org/r/157775
Comment 2 Rolf Theunissen CLA 2021-11-17 04:11:56 EST 
Please consider that SWT is a library, instead of depending on the manifest that is in a random executable, it should be fully self contained.

AFAIK, there should be support in the windows system to fully isolate a DLL that it is not depending on any configuration in the executable that it loads. That is, all the dependencies are specified by the DLL (including version), and nothing is assumed about the environment of the executable.
There is documentation about this, but cannot find it now quickly.

The runtime assembly activation might be a hack, but please consider to make SWT self contained.
Comment 4 Niraj Modi CLA 2022-03-04 00:01:30 EST 
Moving out of 4.23