Bug 570406 - Declare Windows 10 compatibility in the manifest
Summary: Declare Windows 10 compatibility in the manifest
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Launcher (show other bugs)
Version: 4.19   Edit
Hardware: PC Windows All
: P3 enhancement (vote)
Target Milestone: 4.22 M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 551611 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-01-16 01:53 EST by Nikita Nemkin CLA
Modified: 2022-01-18 09:02 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Nemkin CLA 2021-01-16 01:53:01 EST 
Explicit compatibility declaration changes the behavior of some Win32 functions. java/javaw executables already do this (since at least Java 8) and we should minimize the difference.
Comment 1 Eclipse Genie CLA 2021-01-16 01:56:24 EST 
New Gerrit change created: https://git.eclipse.org/r/c/equinox/rt.equinox.framework/+/174915
Comment 2 Sravan Kumar Lakkimsetti CLA 2021-01-19 02:27:10 EST 
Can you please provide a link to the documentation of classid? I would like to review the information.
Comment 3 Sravan Kumar Lakkimsetti CLA 2021-01-19 02:32:13 EST 
found the documentation https://docs.microsoft.com/en-us/windows/win32/sysinfo/targeting-your-application-at-windows-8-1?redirectedfrom=MSDN

The change looks good. Should this one and Bug 560195 merged together?
Comment 4 Nikita Nemkin CLA 2021-01-19 02:48:20 EST 
(In reply to Sravan Kumar Lakkimsetti from comment #3)
> found the documentation
> https://docs.microsoft.com/en-us/windows/win32/sysinfo/targeting-your-
> application-at-windows-8-1?redirectedfrom=MSDN
> 
> The change looks good. Should this one and Bug 560195 merged together?

Yes, this patch makes sure there are no regressions in Eclipse after Bug 560195.
If you think Bug 560195 is fine, feel free to merge both.
Comment 6 Sravan Kumar Lakkimsetti CLA 2021-09-22 08:20:08 EDT 
the launcher has been rebuilt with https://git.eclipse.org/c/equinox/rt.equinox.binaries.git/commit/?id=39eb2d942b9161793e2432239f4ddac932171484
Comment 7 Niraj Modi CLA 2022-01-18 09:02:08 EST 
*** Bug 551611 has been marked as a duplicate of this bug. ***