Bug 558961 - Focus ring with uneven margins in Find Actions / Quick Access dialog
Summary: Focus ring with uneven margins in Find Actions / Quick Access dialog
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.15   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 4.15 M1   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 552662
Blocks:
  Show dependency tree
 
Reported: 2020-01-09 04:32 EST by Noopur Gupta CLA
Modified: 2020-01-10 11:36 EST (History)
3 users (show)

See Also:

Attachments
Screenshot (7.84 KB, image/png)
2020-01-09 04:32 EST, Noopur Gupta CLA 		no flags Details
RHEL 7.4, clearlooks-phenix theme (52.22 KB, image/png)
2020-01-09 08:17 EST, Andrey Loskutov CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2020-01-09 04:32:43 EST 
Created attachment 281425 [details]
Screenshot

I20200106-1805

- Open quick access / find actions dialog.
- Text filter now gets a focus ring with uneven margins.

=> The margin is more at the top compared to the bottom and there is no margin on the left. See attached screenshot.
Comment 1 Noopur Gupta CLA 2020-01-09 08:07:24 EST 
It seems to be coming from bug 552662. Andrew, can you please check?
Comment 2 Andrey Loskutov CLA 2020-01-09 08:17:49 EST 
Created attachment 281429 [details]
RHEL 7.4, clearlooks-phenix theme

Same Ugly thing on RHEL 7.4, both Adwaita and clearlooks-phenix themes (screenshot for later).
Comment 3 Andrey Loskutov CLA 2020-01-09 08:28:25 EST 
(In reply to Noopur Gupta from comment #1)
> It seems to be coming from bug 552662. Andrew, can you please check?

Yes, it is.

I've pushed revert Gerrit for bug 552662, see https://git.eclipse.org/r/155543.

@Noopur: I'm personally fine if this bug will be in M1, but if you think it is worth a new build, we might merge the gerrit above and re-trigger the build.
Comment 4 Noopur Gupta CLA 2020-01-09 08:38:37 EST 
(In reply to Andrey Loskutov from comment #3)
> (In reply to Noopur Gupta from comment #1)
> > It seems to be coming from bug 552662. Andrew, can you please check?
> 
> Yes, it is.
> 
> I've pushed revert Gerrit for bug 552662, see
> https://git.eclipse.org/r/155543.
> 
> @Noopur: I'm personally fine if this bug will be in M1, but if you think it
> is worth a new build, we might merge the gerrit above and re-trigger the
> build.
I am OK to leave it as it is for M1 but we should revert it after that.
Comment 5 Andrew Obuchowicz CLA 2020-01-09 09:43:09 EST 
I appologize for causing this bug, I was clearly focusing too much on fixing Bug 552662 that I failed to notice the issues with the margins. 

I will look into a fix for the margins.
Comment 6 Andrey Loskutov CLA 2020-01-09 10:24:27 EST 
(In reply to Andrew Obuchowicz from comment #5)
> I appologize for causing this bug, I was clearly focusing too much on fixing
> Bug 552662 that I failed to notice the issues with the margins. 
> 
> I will look into a fix for the margins.

I personally not only dislike margins, but the *border* that are now shown around the text. This is what causes users to notice margins in first place.
Comment 7 Sarika Sinha CLA 2020-01-10 01:54:30 EST 
(In reply to Noopur Gupta from comment #4)
> (In reply to Andrey Loskutov from comment #3)
> > (In reply to Noopur Gupta from comment #1)
> > > It seems to be coming from bug 552662. Andrew, can you please check?
> > 
> > Yes, it is.
> > 
> > I've pushed revert Gerrit for bug 552662, see
> > https://git.eclipse.org/r/155543.
> > 
> > @Noopur: I'm personally fine if this bug will be in M1, but if you think it
> > is worth a new build, we might merge the gerrit above and re-trigger the
> > build.
> I am OK to leave it as it is for M1 but we should revert it after that.

Do we want to include this included in M1 as we have the rebuild happening ?
Comment 8 Andrey Loskutov CLA 2020-01-10 02:40:27 EST 
Yes please
Comment 9 Andrey Loskutov CLA 2020-01-10 04:05:13 EST 
Fixed by reverting original commit with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=069df6fc50dc7e625d2cf1067b8dda4004363dc1.
Comment 10 Andrey Loskutov CLA 2020-01-10 11:36:06 EST 
Verified with I20200110-0905