Community
Participate
Working Groups
Our search widgets typically use the SWT.SEARCH style bit with ICON_CANCEL. I suggest to use this also for the Find Action dialog.
Mickael, WDYT?
I don't have an opinion here, as I'm not sure what this would actually change nor where you'd like to apply this. But I'm find in principle in adding the "Search" semantic flag to relevant widgets.
We would get an Cancel icon at the right if the user entered text (see Open Type)
(In reply to Lars Vogel from comment #3) > We would get an Cancel icon at the right if the user entered text (see Open > Type) Ok, that would make sense.
Patrick, something for you?
(In reply to Lars Vogel from comment #5) > Patrick, something for you? Ping?
New Gerrit change created: https://git.eclipse.org/r/155335
Gerrit change https://git.eclipse.org/r/155335 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=18a2c81dfde3e94338c9ca42b1ef59a9b5b891db
New Gerrit change created: https://git.eclipse.org/r/155543
(In reply to Eclipse Genie from comment #9) > New Gerrit change created: https://git.eclipse.org/r/155543 Revert of original commit, because it caused bug 558961. I wonder on which system this was validated, if it looks ugly on both GTK/Windows.
Created attachment 281433 [details] Find actions with cancel icon using dark GTK theme (In reply to Andrey Loskutov from comment #10) > (In reply to Eclipse Genie from comment #9) > > New Gerrit change created: https://git.eclipse.org/r/155543 > > Revert of original commit, because it caused bug 558961. > > I wonder on which system this was validated, if it looks ugly on both > GTK/Windows. It was validated on GTK. At the time of writting the patch I didn't notice the issue with the margins, and it looks slighly better with Adwaita-Dark GTK theme compared to other GTK themes (see screenshot attached). Regardless I should have been more critical of how the margins were affected. Especially with a light GTK theme. Will be looking into a fix.
Reverting minor UI issues before someone can have a look at it, seems like a overeaction. I personally don't even notice the margins but having the cancel icon is really helpful (to me).
(In reply to Lars Vogel from comment #12) > Reverting minor UI issues before someone can have a look at it, seems like a > overeaction. I personally don't even notice the margins but having the > cancel icon is really helpful (to me). It looks just ugly now on GTK, for two themes, Adwaita and Clearlooks (also on Windows), so why it is overreacting to revert something that makes things worse as before? It is not about margins, it is about that border around text, and the resulting look.
(In reply to Andrey Loskutov from comment #13) > (In reply to Lars Vogel from comment #12) > > Reverting minor UI issues before someone can have a look at it, seems like a > > overeaction. I personally don't even notice the margins but having the > > cancel icon is really helpful (to me). > > It looks just ugly now on GTK, for two themes, Adwaita and Clearlooks (also > on Windows), so why it is overreacting to revert something that makes things > worse as before? It is not about margins, it is about that border around > text, and the resulting look. Because we are still in development and not before a release so we not in a rush and "but this is just about L&F, not a functional issue." to quote yourself from https://bugs.eclipse.org/bugs/show_bug.cgi?id=558953#c4
(In reply to Lars Vogel from comment #12) > Reverting minor UI issues before someone can have a look at it, seems like a > overeaction. I personally don't even notice the margins but having the > cancel icon is really helpful (to me). I appreciate the support on the patch Lars (as mentioned I didn't notice the margins either). I should add, however, that I'm totally fine with Andrey reverting this. Had I personally noticed the issue prior to submitting the patch, I would have waited till I found a proper fix to the margin issues.
(In reply to Andrew Obuchowicz from comment #15) > I should add, however, that I'm totally fine with Andrey reverting this. Had > I personally noticed the issue prior to submitting the patch, I would have > waited till I found a proper fix to the margin issues. IMHO we should reserve reverts for real issue and not more minor UI glitches. Reverts send IMHO the strong message of "this was not acceptable and must be removed. Fast!". I prefer to give the developer time to invest if the issue can be fixed without the revert. If the person does not find a way or does not react we still can revert.
(In reply to Lars Vogel from comment #16) > (In reply to Andrew Obuchowicz from comment #15) > > > I should add, however, that I'm totally fine with Andrey reverting this. Had > > I personally noticed the issue prior to submitting the patch, I would have > > waited till I found a proper fix to the margin issues. > > IMHO we should reserve reverts for real issue and not more minor UI glitches. > > Reverts send IMHO the strong message of "this was not acceptable and must be > removed. Fast!". I prefer to give the developer time to invest if the issue > can be fixed without the revert. If the person does not find a way or does > not react we still can revert. If you look on the patch, there isn't much to be "fixed" except to revert it. And I meant it is not worth the effort to retrigger the M1 rebuild only because of this one issue. Now we have a bigger problem and rebuild request anyway, I will merge reverted patch.
Gerrit change https://git.eclipse.org/r/155543 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=069df6fc50dc7e625d2cf1067b8dda4004363dc1
(In reply to Andrey Loskutov from comment #17) > If you look on the patch, there isn't much to be "fixed" except to revert > it. Fixing the margins would IMHO be the right fix.
(In reply to Lars Vogel from comment #19) > (In reply to Andrey Loskutov from comment #17) > > > If you look on the patch, there isn't much to be "fixed" except to revert > > it. > > > Fixing the margins would IMHO be the right fix. Please look on the GTK screenshots. Not margins is the biggest problem there, but border. They make the UI looks bad.
(In reply to Andrey Loskutov from comment #20) > (In reply to Lars Vogel from comment #19) > > (In reply to Andrey Loskutov from comment #17) > > > > > If you look on the patch, there isn't much to be "fixed" except to revert > > > it. > > > > > > Fixing the margins would IMHO be the right fix. > > Please look on the GTK screenshots. Not margins is the biggest problem > there, but border. They make the UI looks bad. Isn't that our SWT default? Do you see same issue in the Preference search field?
Retarget.
