Community
Participate
Working Groups
Versions: MacOS Catalina, 10.15.2 openjdk version "11.0.5" 2019-10-15 OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.5+10) OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.5+10, mixed mode) Eclipse 2019-12, up to date as of 2020-01-03, 12:00 UTC; Build id: 20191212-1212; eclipse for java developers (though in place updated from 2019-09 (or possibly earlier)) Setting the background color for text editors (preferences > general > editors > text editors) only takes effect between the time one clicks apply, and closes the window. uppon closing the window, the gutter behind the line numbers remains the correct color, but the background of the text area returns to rgb(47,47,47), which occurs nowhere in my exported settings.epf. The background color in said settings.epf appears to be correct: (assuming this is the correct line) "/instance/org.eclipse.ui.editors/AbstractTextEditor.Color.Background=0,0,0" Main appearance is set to dark[linux] but appeared to occur when set to "Dark" as well as "Dark [windows]" (asside: I previously started using "dark [linux]" because macOS detection from version to version occasionally removes the "dark" option. Preferences recorder is disabled, so I cannot think of anything else that would suddenly change the appearance after closing the preferences window after applying the color. This issue also occurs on build I20200101-1800. Let me know if there is anything I can test or output/debug/log/etc I can provide to help. Thanks.
Thanks for the detailed report Dave. Can reproduce on Windows 7. No problem in Light theme but the behavior you described in Dark theme. Using "Apply and close" has the same outcome. @Lars you probably know some Dark Theme/CSS experts for this.
I see exactly the same behaviour. A few times the selected background color stayed even after closing the preferences window but then after any interaction with the editor window the grey background color immediately returns.
We do set 'AbstractTextEditor.Color.Background=47,47,47' via e4-dark_preferencestyle.css but that has been the case since a long time. But user settings should have priority over CSS. I'm not aware of any change we did in the 2019-12 release in the CSS preference handling. In this release did this work?
Can you clarify what you mean by 'In this release did this work?'? Thanks
(In reply to Dave Null from comment #4) > Can you clarify what you mean by 'In this release did this work?'? > > Thanks Sorry, typo. You are saying this is a regression. So in which release did this work?
Every release prior to and including 2019-09 as far as I'm aware. I was running 2019-09 prior to upgrading to 2019-12 with the 'dark[linux]' overall theme, and the abstract editor background set to 0,0,0. My editor background has always been black (0,0,0) since eclipse... io? 10+ years ago. I have also used the "dark" UI chrome since it became an option a couple of years ago. Thanks.
On my laptop (which still has 2019-09), checked for updates to platform and 2019-09. MacOS 10.15.2, adoptopenjdk 1.8.0_232, eclipse build 20190917-1200. Overall appearance theme: Dark [Linux] set general > editors > text editors > background color to hot pink, then back to 0,0,0. works as expected. Let me know if I can check anything else. Thanks.
Anything else I can test to move this along?
I just did a quick test with the newly released version 2020-03 and the bug is still there of course. But now it seems that the preferences dialog also has issues since the settings "General->Editors->Text Editors" shows the list "Appearance color options" either with the text labels flipped horizontally (see picture 1) but still selectable, or as a thin line of garbage with nothing selectable (see picture 2).
Created attachment 282141 [details] broken preferences 1
Created attachment 282142 [details] broken preferences 2
(In reply to Martin Weiser from comment #9) > I just did a quick test with the newly released version 2020-03 and the bug > is still there of course. > But now it seems that the preferences dialog also has issues since the > settings "General->Editors->Text Editors" shows the list "Appearance color > options" either with the text labels flipped horizontally (see picture 1) > but still selectable, or as a thin line of garbage with nothing selectable > (see picture 2). Please open a new bug for that. Btw. I cannot produce on Linux.
(In reply to Lars Vogel from comment #12) > (In reply to Martin Weiser from comment #9) > > I just did a quick test with the newly released version 2020-03 and the bug > > is still there of course. > > But now it seems that the preferences dialog also has issues since the > > settings "General->Editors->Text Editors" shows the list "Appearance color > > options" either with the text labels flipped horizontally (see picture 1) > > but still selectable, or as a thin line of garbage with nothing selectable > > (see picture 2). > > Please open a new bug for that. Btw. I cannot produce on Linux. Someone else was faster: BUG 561235
I wonder if this is related to the change made in Bug 548057? A list used to be used, which was changed to table (so that the color previews could be made visible from within the table). Note that the change was made & tested on Linux only.
This bug still exists as of the following Eclipse version: Version: 2020-09 (4.17) Build id: I20200902-1800 This is quite frustrating. Please fix this regression! For the afflicted, some workarounds can be found here: https://stackoverflow.com/questions/59599251/eclipse-2019-black-background and here: https://stackoverflow.com/questions/60450156/eclipse-4-14-0-changing-the-editor-background-colour
Note that this bug report may be a duplicate of bug 559321.
This definetly needs to get fixed for 2020-12 as it is quite annoying. I did some quick testing and it seems that the only the line number background gets modified when hitting apply and close on the text editor color preferences. I believe the actual text editor background gets overriden by the theme's CSS. My argument is based on the following workaround which was suggested, which involves modifying eclipse's dark CSS to change the editor background: > > For the afflicted, some workarounds can be found here: > > https://stackoverflow.com/questions/59599251/eclipse-2019-black-background In Spectrum Theme (which was originally based on the Platform Dark Theme), we have similar CSS and it also takes precedence over the editor background color (so the bug exists for Spectrum Theme as well). https://github.com/AObuchow/Eclipse-Spectrum-Theme/blob/master/com.aobuchow.themes.spectrum/css/default_overrides.css#L280 I wonder what change caused this bug: - was it a change in the CSS? (eg. the CSS mentioned in the workaround was added in) - was it a change in the CSS handler? (eg. CSS mistakenly takes priority over preferences) - something else?
> > I wonder what change caused this bug: > - was it a change in the CSS? (eg. the CSS mentioned in the workaround was > added in) So I reverted some CSS patches made before 2020-09 and I think the bug is coming from https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/152281/ as the commit before this change does not have this bug. I can see .MPart Composite > *, .MPart Composite > * > *, was added to the e4 dark part style, this is probably overriding the text editors preferences. I might be mistaken though, it's late and I have to go to bed :)
I am still seeing this problem on Eclipse 4.22: Version: 2021-12 (4.22) Build id: I20211124-1800 OS: Windows 10, v.10.0, x86_64 / win32 I would love for this to be fixed so that I don't have to manually modify obscure config files each time I upgrade eclipse! Please fix this!
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/188920
*** Bug 577472 has been marked as a duplicate of this bug. ***
*** This bug has been marked as a duplicate of bug 559321 ***
