Community
Participate
Working Groups
- Would be nice to see color previews in all the rows of the "Appearance color options" table. - This might make the table very crowded, to resolve this I suggest: - Moving the "Color:" label and it's associated color choose button to the right - Extending the right border/side of the "Appearance color options" table with the space gained from moving the color picker. JFace Snippet003 demonstrates a possible way to display color previews in a table: https://wiki.eclipse.org/JFaceSnippets#Snippet003_-_Table_Label_Provider
Created attachment 278856 [details] Suggested widget placement + table color preview
Created attachment 278857 [details] Improved clarity of Suggested Fix image
Where it occurs: Preferences -> General -> Editors -> Text Editors (near the bottom of the window)
(In reply to Andrew Obuchowicz from comment #0) > - Would be nice to see color previews in all the rows of the "Appearance > color options" table. > > - This might make the table very crowded, to resolve this I suggest: > - Moving the "Color:" label and it's associated color choose button to > the > right > - Extending the right border/side of the "Appearance color options" > table > with the space gained from moving the color picker. > > JFace Snippet003 demonstrates a possible way to display color previews in a > table: > https://wiki.eclipse.org/JFaceSnippets#Snippet003_-_Table_Label_Provider Additionally, the user should be able to open up a color picker by clicking on a color preview from the table (inline editing behaviour)
That's the Platform's preference page.
(In reply to Nitin Dahyabhai from comment #5) > That's the Platform's preference page. Can you clarify what you mean by this?
(In reply to Andrew Obuchowicz from comment #6) > Can you clarify what you mean by this? Both of your screenshots are from preference pages that come from the Eclipse Platform, not the Web Tools Platform, the opposite of what's shown in bug 548061.
(In reply to Nitin Dahyabhai from comment #7) > (In reply to Andrew Obuchowicz from comment #6) > > Can you clarify what you mean by this? > > Both of your screenshots are from preference pages that come from the > Eclipse Platform, not the Web Tools Platform, the opposite of what's shown > in bug 548061. I see, what should I modify? The bug is currently filed against Platform/UI.
(In reply to Nitin Dahyabhai from comment #5) > That's the Platform's preference page. Sorry, my bad. But bug 548168 is for the Structured Text Editor.
(In reply to Dani Megert from comment #9) > Sorry, my bad. But bug 548168 is for the Structured Text Editor. The Gerrit for it isn't, and its use of asyncExec gives me pause for crafting corresponding changes there.
(In reply to Nitin Dahyabhai from comment #10) > (In reply to Dani Megert from comment #9) > > Sorry, my bad. But bug 548168 is for the Structured Text Editor. > > The Gerrit for it isn't, and its use of asyncExec gives me pause for > crafting corresponding changes there. I agree to both, nevertheless the bug is about the Structured Editors page and should be moved out of Platform again.
(In reply to Nitin Dahyabhai from comment #10) > (In reply to Dani Megert from comment #9) > > Sorry, my bad. But bug 548168 is for the Structured Text Editor. > > The Gerrit for it isn't, and its use of asyncExec gives me pause for > crafting corresponding changes there. I appologize for the confusion, Nitin - I made a mistake when posting the gerrit change initially (used the wrong bug #). The associated gerrit change for this bug is: https://git.eclipse.org/r/#/c/146099/ As for asyncExec, it's usage will be removed if my change gets merged.
Gerrit change https://git.eclipse.org/r/146099 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=a3b2be38834b90fe30764230803ea9390fce3334
Thanks Andrew. Please add a note to the N&N
(In reply to Mickael Istria from comment #14) > Thanks Andrew. Please add a note to the N&N Will do !
New Gerrit change created: https://git.eclipse.org/r/146572
Gerrit change https://git.eclipse.org/r/146572 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=cb22a2ca2f6c21e6bb33ff4e66b72fd43ac919dc
> Additionally, the user should be able to open up a color picker by clicking on > a color preview from the table (inline editing behaviour) This was not implemented. Updated summary.
