Bug 553244 - Find Actions shows chevron menu icon and not the new Kebab icon
Summary: Find Actions shows chevron menu icon and not the new Kebab icon
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.14   Edit
Hardware: All Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 551604
  Show dependency tree
 
Reported: 2019-11-20 02:38 EST by Sarika Sinha CLA
Modified: 2020-05-07 09:05 EDT (History)
6 users (show)

See Also:


Attachments
Chevron in find actions popup (65.79 KB, image/png)
2019-11-20 03:20 EST, Paul Pazderski CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sarika Sinha CLA 2019-11-20 02:38:28 EST
I expected Find Actions to show the new Kebab icon.
Comment 1 Ed Merks CLA 2019-11-20 02:43:39 EST
That doesn't make sense to me. Pushing it doesn't bring up a menu.  There is a context menu,  which is also true for the perspective buttons, but that's independent of what pushing the button does and the icon should reflect the action of pushing the button...
Comment 2 Lars Vogel CLA 2019-11-20 02:51:12 EST
(In reply to Ed Merks from comment #1)
> That doesn't make sense to me. Pushing it doesn't bring up a menu.  There is
> a context menu,  which is also true for the perspective buttons, but that's
> independent of what pushing the button does and the icon should reflect the
> action of pushing the button...

+1, why would we want a kebab menu on a tool item?
Comment 3 Lars Vogel CLA 2019-11-20 02:52:42 EST
Ah, I think Sarika means the "Find Actions" dialog. Reopening.

Sarika, please attach a sceenshot.
Comment 4 Lars Vogel CLA 2019-11-20 03:06:34 EST
For reference: Open Type uses the Kebab menu.
Comment 5 Paul Pazderski CLA 2019-11-20 03:20:01 EST
Created attachment 280717 [details]
Chevron in find actions popup

I assume Sarika means the one inside the text field. Which is also the difference to all other usage of the new icon. None is inside a text field afaik.
Comment 6 Sarika Sinha CLA 2019-11-20 04:01:16 EST
(In reply to Paul Pazderski from comment #5)
> Created attachment 280717 [details]
> Chevron in find actions popup
> 
> I assume Sarika means the one inside the text field. Which is also the
> difference to all other usage of the new icon. None is inside a text field
> afaik.

Yes, Thanks!
Comment 7 Wim Jongman CLA 2019-11-20 09:15:03 EST
(In reply to Ed Merks from comment #1)
> That doesn't make sense to me. Pushing it doesn't bring up a menu.  There is
> a context menu,  which is also true for the perspective buttons, but that's
> independent of what pushing the button does and the icon should reflect the
> action of pushing the button...

A menu is a menu. Pop-up, pull-down, context, main menu. They are all the same.

We should be consistent with our presentation and replace the stand-alone chevron with the kebab menu everywhere.
Comment 8 Ed Merks CLA 2019-11-20 09:26:06 EST
(In reply to Wim Jongman from comment #7)
> (In reply to Ed Merks from comment #1)
> > That doesn't make sense to me. Pushing it doesn't bring up a menu.  There is
> > a context menu,  which is also true for the perspective buttons, but that's
> > independent of what pushing the button does and the icon should reflect the
> > action of pushing the button...
> 
> A menu is a menu. Pop-up, pull-down, context, main menu. They are all the
> same.
> 
> We should be consistent with our presentation and replace the stand-alone
> chevron with the kebab menu everywhere.

If you look closely at the thread, there was confusion over what the terminology "Find Actions" referred to. The button with that label/hover versus the dialog that comes up (which isn't labeled Find Actions, hence the misunderstanding).  

Of course I think we all agree that if we're going to use the kebab for menus, then the menu button in the dialog should also use it.  I.e., one can't argue against consistency. :-P

I see that icon is a different color than the one that was formerly in the view menu so likely a different icon and hence overlooked.
Comment 9 Wim Jongman CLA 2019-11-20 09:57:33 EST
(In reply to Ed Merks from comment #8)

> 
> If you look closely at the thread, there was confusion over what the
> terminology "Find Actions" referred to. The button with that label/hover
> versus the dialog that comes up (which isn't labeled Find Actions, hence the
> misunderstanding).  

Yes, apologies. I did not read the whole thread.
Comment 10 Michael Vogt CLA 2020-05-07 08:57:50 EDT
Why was the icon changed at all? I didn't use 4.14 and now see it first in 4.15.

Besides seeing inconsistencies (compare to other "drop down" actions) I do not see any value add by having the new icon. It first of all confuses users since they need to "learn" it first. What was wrong with the old icon? Maybe you can point me to a thread where that topic was discussed. Sorry for spaming this bug with my question.
Comment 11 Paul Pazderski CLA 2020-05-07 09:05:16 EDT
(In reply to Michael Vogt from comment #10)
> Maybe you can point me to a thread where that topic was discussed.

Bug 551604.