Community
Participate
Working Groups
Created attachment 280713 [details] java build path page Build: I20191110-1800 The look of the preference pages/wizards with Table or Tree has changed since 4.13 M1. They look odd and confusing now without differentiating background or border. Please see attached screenshots for some examples on Mac. Problem is seen on Linux as well, there is no differentiating background but there is a black border which still looks odd. I've not checked on Windows yet.
Created attachment 280714 [details] preferences page
Created attachment 280715 [details] new wizard
@Lars, I've not verified, but going by the bug looks like this is caused by -https://bugs.eclipse.org/bugs/show_bug.cgi?id=551707. This change makes the all the Wizard pages and a lot of preferences pages look bad... please see the attached screenshots.
(In reply to Lakshmi Shanmugam from comment #3) > @Lars, > I've not verified, but going by the bug looks like this is caused by > -https://bugs.eclipse.org/bugs/show_bug.cgi?id=551707. > This change makes the all the Wizard pages and a lot of preferences pages > look bad... please see the attached screenshots. I mean on Mac dark theme.
Using the same color consistently was the intent of the change in Bug 551707.
(In reply to Lars Vogel from comment #5) > Using the same color consistently was the intent of the change in Bug 551707. And IMHO this looks way better now.
Created attachment 280721 [details] Preference page Dark Theme on RHEL 7.7 Demarcation between the left and right panes is missing.
Created attachment 280722 [details] Preferences with Scrollbars on Mac It looks even worse, if scrollbars are visible.
Created attachment 280723 [details] quick search preference page (In reply to Lars Vogel from comment #6) > (In reply to Lars Vogel from comment #5) > > Using the same color consistently was the intent of the change in Bug 551707. > > And IMHO this looks way better now. If you look at the screenshots, especially the quick search and content-types preferences pages, there are no borders or color to differentiate the content... it's very confusing.
Sounds like most people dislike the alignment of colors for trees in dialogs. I can look at providing a patch next week, this week I work on something else. If someone wants to take this for M3 the selector Shell Tree { } should allow to style trees in dialogs.
(In reply to Lars Vogel from comment #10) > Sounds like most people dislike the alignment of colors for trees in > dialogs. > > I can look at providing a patch next week, this week I work on something > else. If someone wants to take this for M3 the selector > > Shell Tree { > > } > > should allow to style trees in dialogs. Thanks Lars. Please fix for RC1.
+1 to fix for 4.14.
(In reply to Lars Vogel from comment #10) > Sounds like most people dislike the alignment of colors for trees in > dialogs. > > I can look at providing a patch next week, this week I work on something > else. If someone wants to take this for M3 the selector > > Shell Tree { > > } > > should allow to style trees in dialogs. Ping!
(In reply to Lakshmi Shanmugam from comment #13) > (In reply to Lars Vogel from comment #10) > > Sounds like most people dislike the alignment of colors for trees in > > dialogs. > > > > I can look at providing a patch next week, this week I work on something > > else. If someone wants to take this for M3 the selector > > > > Shell Tree { > > > > } > > > > should allow to style trees in dialogs. > > Ping! I plan to look at this tomorrow or the say after
New Gerrit change created: https://git.eclipse.org/r/153471
(In reply to Eclipse Genie from comment #15) > New Gerrit change created: https://git.eclipse.org/r/153471 Lakshmi, please test and give feedback.
(In reply to Lars Vogel from comment #16) > (In reply to Eclipse Genie from comment #15) > > New Gerrit change created: https://git.eclipse.org/r/153471 > > Lakshmi, please test and give feedback. looks good on macOS. +1
(In reply to Lars Vogel from comment #16) > (In reply to Eclipse Genie from comment #15) > > New Gerrit change created: https://git.eclipse.org/r/153471 > > Lakshmi, please test and give feedback. Thanks Lars! Looks great on Mac.
Thanks Niraj for testing on Windows.
(In reply to Lakshmi Shanmugam from comment #19) > Thanks Niraj for testing on Windows. Thanks to you both!
Gerrit change https://git.eclipse.org/r/153471 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=988bdaff7d295db424e1ef166f762427058faa7d
Verified with I20191127-1800
