Community
Participate
Working Groups
Not sure why but the current dark theme uses a lot of slightly different colors for its widgets. This makes the UI looks overloaded. Compare this with VScode which looks much better because it uses only a few colors. The majority of the widgets uses the following setting, I suggest we try to move more widgets to this setting: background-color:#515658; color:#eeeeee;
New Gerrit change created: https://git.eclipse.org/r/150497
Gerrit change https://git.eclipse.org/r/150497 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4b54ca80398334b8dc39d003b7d06feb180728a3
New Gerrit change created: https://git.eclipse.org/r/151313
Created attachment 280332 [details] Tree and table Result if we use the same color for trees and tables.
I also suggest to use the same colors as we use for all widgets for trees and tables, see screenshot.
New Gerrit change created: https://git.eclipse.org/r/151315
(In reply to Lars Vogel from comment #4) > Created attachment 280332 [details] > Tree and table > > Result if we use the same color for trees and tables. left is old, right is new?
(In reply to Matthias Becker from comment #7) > (In reply to Lars Vogel from comment #4) > left is old, right is new? Yes.
Created attachment 280339 [details] Another example using the Launch configuration old is on the left, new is on the right
Created attachment 280340 [details] Views having different background colors Another example for inconsistent usage of colors, in the attached examples I have several empty views open and IMHO all should use the same background color but we we different "grays" being used.
+1, no more 50 shades of grey ;)
Gerrit change https://git.eclipse.org/r/151315 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2e0644a9c831cf46ccc5e3f6f25ad349e7b69da0
New Gerrit change created: https://git.eclipse.org/r/151506
While really I appreciate your work on this, I must say that commit 2e0644a9c831cf46ccc5e3f6f25ad349e7b69da0 is not a good idea on the mac. The package explorer etc. now have background that is much brighter than the editor, making it harder to read and it looks like there are MORE not less differently colors areas. I'll attach screen shots.
(In reply to Till Brychcy from comment #14) > While really I appreciate your work on this, I must say that commit > 2e0644a9c831cf46ccc5e3f6f25ad349e7b69da0 is not a good idea on the mac. > > The package explorer etc. now have background that is much brighter than the > editor, making it harder to read and it looks like there are MORE not less > differently colors areas. > > I'll attach screen shots. Thanks.
Created attachment 280400 [details] without 2e0644a9c8
Created attachment 280401 [details] with 2e0644a9c8
Till, are you available to investigate why this looks bad on Mac but good on Linux? I could revert 2e0644a9c8 (and make Linux uglier again) or add the tree specific styling only to the Mac which I also think is a not optimal solution, as it effectively decouples dark styling changes between the different OS. With Mac access I cannot investigate myself.
Looks like we do have a lot of redundancy in dark styling in the OSS specific css files. Open Bug 552368 to factor them out.
New Gerrit change created: https://git.eclipse.org/r/151590
New Gerrit change created: https://git.eclipse.org/r/151717
Gerrit change https://git.eclipse.org/r/151590 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a8fd7f66cdee4d9290e3be4f83f7208ee98c6509
(In reply to Lars Vogel from comment #18) > Till, are you available to investigate why this looks bad on Mac but good on > Linux? > > I could revert 2e0644a9c8 (and make Linux uglier again) or add the tree > specific styling only to the Mac which I also think is a not optimal > solution, as it effectively decouples dark styling changes between the > different OS. With Mac access I cannot investigate myself. The color comes from the rule Tree, RegistryFilteredTree { background-color:#515658; color:#eeeeee; } #515658 is pretty bright and not a good background color for editors (and the trees in package explorer etc. should match the editors). I wonder how this is NOT broken on linux?
Btw. the patch for bug 552691 has changed the background for editors to the same gray. The master is currently completely unusable for me. I guess it was pretty optimistic of you to change all this without testing on all platforms. Maybe it would be better to roll back all dark mode css changes until you have access to a mac or at least a tester with a mac (I currently don't have time to work on this.)
(In reply to Till Brychcy from comment #24) > Btw. the patch for bug 552691 has changed the background for editors to the > same gray. The master is currently completely unusable for me. > > I guess it was pretty optimistic of you to change all this without testing > on all platforms. > > Maybe it would be better to roll back all dark mode css changes until you > have access to a mac or at least a tester with a mac (I currently don't have > time to work on this.) Matthias helps with testing in Mac, unfortunately I did not involve him for Bug 552691.
(In reply to Till Brychcy from comment #23) > I wonder how this is NOT broken on linux? Looks like e4-dark.css contains special Linux styling for Trees and Canvas. If I remove that, I also have light Explorer and Outline view. I push a Gerrit soon.
New Gerrit change created: https://git.eclipse.org/r/152129
Created attachment 280525 [details] Comparison Windows (In reply to Eclipse Genie from comment #27) > New Gerrit change created: https://git.eclipse.org/r/152129 Comparison on Windows, no visible difference for me...
Gerrit change https://git.eclipse.org/r/152129 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9c723996f09b9f5ae18fc68129f4a3102f37ceb7
Till, please reopen if parts on Mac still look worse. For the remaining cleanup work in the dark theme I will use dedicated bugs.
(In reply to Lars Vogel from comment #30) > Till, please reopen if parts on Mac still look worse. For the remaining > cleanup work in the dark theme I will use dedicated bugs. Please see https://bugs.eclipse.org/bugs/show_bug.cgi?id=553242 for problems on Mac.
@Lars, Can you please update the 'New' image in the N&N entry - https://www.eclipse.org/eclipse/news/4.14/platform.php#dark-colors-usage.
