Bug 552413 - Menu in toolbar is disabled
Summary: Menu in toolbar is disabled
Status: CLOSED DUPLICATE of bug 552659
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.13   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Rolf Theunissen CLA
QA Contact:
URL:
Whiteboard:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2019-10-25 05:03 EDT by Gabi Boros CLA
Modified: 2019-11-06 07:05 EST (History)
4 users (show)

See Also:

Attachments
sample eclipse application (122.72 KB, application/zip)
2019-10-25 05:03 EDT, Gabi Boros CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabi Boros CLA 2019-10-25 05:03:26 EDT 
Created attachment 280417 [details]
sample eclipse application

There seems to be a regression in 4.13 (versus 4.12) related to menus enable status. Please have a look on the attached sample application: if you open the drop-down from the first item in the toolbar, you will see that the second menu entry is disabled, but this is not the case in 4.12. Could be this related to this case: https://bugs.eclipse.org/bugs/show_bug.cgi?id=547050 ?
Comment 1 Andrey Loskutov CLA 2019-10-25 11:48:44 EDT 
(In reply to Gabi Boros from comment #0)
> Created attachment 280417 [details]
> sample eclipse application
> 
> There seems to be a regression in 4.13 (versus 4.12) related to menus enable
> status. 

What "seems" means: did it worked in 4.12 or not?

> Could be
> this related to this case:
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=547050 ?

Probably not, reverting the change doesn't fix your example.

May be bug 552361?

You could help if you would check out platform UI code and bisect to the commit that breaks your application.

See https://wiki.eclipse.org/Platform/How_to_Contribute
Comment 2 Johan Compagner CLA 2019-10-25 13:57:29 EDT 
no it works in 4.12 (if you switch between target platforms you can see that in the sample)
But it doesn't work in 4.13

But there is something weird..
Under Linux the menu items never enabled what ever you do.
Under Windows the menu is first disabled, but if you click on it, they are suddenly getting enabled
And i think under OSX they are just enabled all the time...
Comment 3 Rolf Theunissen CLA 2019-10-27 07:19:49 EDT 
Bug 20298 and Bug 30423 are related, I don't think it is Bug 552361.

Something changed that made the UI widgets to only be created when the become really visible. The current code checks for the UI widgets for the sub-menus to be available, which is no longer true as they are only created at the first time they are showed.
Comment 4 Andrey Loskutov CLA 2019-11-04 07:56:41 EST 
See also bug 552659.
Comment 5 Sebastian Ratz CLA 2019-11-06 07:05:21 EST 

*** This bug has been marked as a duplicate of bug 552659 ***