Bug 30423 - [Contributions] updating: MenuManager#updateMenuItem() incorrect
Summary: [Contributions] updating: MenuManager#updateMenuItem() incorrect
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 30833
Blocks:
  Show dependency tree
 
Reported: 2003-01-28 15:14 EST by Simon Arsenault CLA
Modified: 2019-10-27 07:19 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Arsenault CLA 2003-01-28 15:14:05 EST
The purpose of this method it seems is to disable the menu item of a sub-menu 
if all the items within the sub-menu are disabled. The correct is incorrect as 
it does not handle the situation where some of the items of the sub-menu are 
separators or groups - these always return true for enablement.

However, if we add an if statement to ignore separators and groups, the menu 
item will become disabled. This causes another problem in the UI. Because the 
menu item of the sub-menu is disabled, there is no way to show the sub-menu. 
This is really problematic is the menu item represents one of the main menu 
item on the menu bar. For example, starting Eclipse with no editors open, 
the "Edit" menu item is disabled and there is not way to show it's sub-menu 
items.

The windows guideline recommend disabling the menu item of a sub-menu whose 
items are also all disabled. But it also seems to indicate that access to the 
sub-menu should still be accessible. But I'm not seeing that behavior at least 
on Win 2000. Do not know if this is an SWT problem or a platform problem. Also, 
looking at various Microsoft apps, they do not disable the menu item of a sub-
menu whose items are all disabled. The exception was Outlook on XP.
Comment 1 Simon Arsenault CLA 2003-01-28 15:14:31 EST
To be looked at for 2.2 stream.
Comment 2 Paul E. Keyser CLA 2003-01-31 14:12:31 EST
Seems like there could be three behaviors of the submenu item: 
1) always enabled, even when its items are not enabled (as now) 
2) enabled iff at least one of its items is enabled (my preference, not 
in any way available now) 
3) visible iff at least one of its items is enabled (what I was able to kludge 
together on 2.0 code) 

Why not programmatically allow all three?  That would just mean allowing # 2, 
since # 1 and # 3 are currently allowed. 
Comment 3 Simon Arsenault CLA 2003-01-31 15:08:36 EST
Doing #2 would not be a problem if the user could still select the disabled sub-
menu item and have its sub-menu made visible (with all items inside of it 
disabled). Currently, the OS will not allow the sub-menu to show when the sub-
menu item is disabled. Our usuability results indicate not allowing the sub-
menu to be shown is more problematic than having the sub-menu item enabled even 
thought all sub-menu items are disabled.
Comment 4 Michael Van Meekeren CLA 2006-04-21 13:56:42 EDT
Moving Dougs bugs
Comment 5 Paul Webster CLA 2007-04-05 19:02:00 EDT
Assigning to component owner
PW
Comment 6 Paul Webster CLA 2007-06-20 12:40:24 EDT
This will not be worked on.  Please re-open if you feel the community should
get a crack at them.