Community
Participate
Working Groups
Using Eclipse on Windows at a customer side and Eclipse styling for the toolbar seems out-of-place. AFAICS the windows toolbar styling is flat and grey, we should adjust our styling to that.
Paul, IIRC you are primary a windows user. Do you know which color code is used on Win10 for the toolbar?
(In reply to Lars Vogel from comment #1) > Paul, IIRC you are primary a windows user. Do you know which color code is > used on Win10 for the toolbar? No. I just know that I find other toolbars worse in Windows 10 than it was in Windows 7. (just like other design changes in Windows 10) I couldn't even immediately name an application where I would say this is a standard one. In my memory they are all out-of-place or ugly or in the imo undesirable ribbon style.
*** Bug 562575 has been marked as a duplicate of this bug. ***
Created attachment 282605 [details] Screenshot Windows 10 seems to be using light gray for its toolbars
The easiest way of getting closer to to normal windows style seems to be the removal of some of our stlying rules.
Created attachment 282606 [details] Screenshot of removed theming for trimbars, windows background This shows (right side) how Eclipse looks like if I remove the hard-coded colors from the light theme. Looks way better to me.
New Gerrit change created: https://git.eclipse.org/r/161669
(In reply to Lars Vogel from comment #6) > Created attachment 282606 [details] > Screenshot of removed theming for trimbars, windows background > > This shows (right side) how Eclipse looks like if I remove the hard-coded > colors from the light theme. Looks way better to me. Hmmm... The thing I find odd is that the tab headers themselves are still blue-ish. It's even more noticeable now that the toolbar just above has switched to grey.
Grey toolbar and grey tab headers are easy to archive. Just enable the classic theme.
(In reply to Pierre-Yves B. from comment #8) > Hmmm... The thing I find odd is that the tab headers themselves are still > blue-ish. It's even more noticeable now that the toolbar just above has > switched to grey. I think moving the tabs to grey would be the next step. Can you provide a Gerrit to move the tabs to grey?
(In reply to Paul Pazderski from comment #9) > Grey toolbar and grey tab headers are easy to archive. Just enable the > classic theme. Still makes sense to improve the default themes.
(In reply to Lars Vogel from comment #10) > I think moving the tabs to grey would be the next step. Can you provide a > Gerrit to move the tabs to grey? My big challenge at the moment is to get a workspace up and running again. Trying to check out a fresh Platform UI workspace has not proven successful yet, Oomph just keeps on failing at some point. That's probably not an Eclipse problem but rather the Internet connection during confinement, it's extremely slow (~300-350 kB/s when I'm the only one using it). The Git checkout on such a huge repository simply fails/times out randomly on some files. Will keep on trying, but can't promise anything.
(In reply to Pierre-Yves B. from comment #12) > (In reply to Lars Vogel from comment #10) > > I think moving the tabs to grey would be the next step. Can you provide a > > Gerrit to move the tabs to grey? > > My big challenge at the moment is to get a workspace up and running again. You do not need Oomph for platform UI setup. Just follow: https://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html#clone-the-selected-eclipse-git-repository
Created attachment 282674 [details] Tab color and radius rework Here's what I came up with. What do people think? It's quite a big change compared to the current blue-ish theme and it's probably not perfect, but if people think it's going in the right direction, I can submit a patch when Gerrit is back up and running again.
(In reply to Pierre-Yves B. from comment #14) > Created attachment 282674 [details] > Tab color and radius rework > > Here's what I came up with. What do people think? It's quite a big change > compared to the current blue-ish theme and it's probably not perfect, but if > people think it's going in the right direction, I can submit a patch when > Gerrit is back up and running again. Looks good to me, please provide Gerrit
New Gerrit change created: https://git.eclipse.org/r/161939
The(In reply to Lars Vogel from comment #15) > Looks good to me, please provide Gerrit* There you go! Note to avoid any confusion: the screenshot I took is the result with BOTH patches (161669 and 161939) combined together. I've modified the bug title so that it mentions the toolbar as well as the tabs, as it probably makes sense to change both for consistency.
I suggest to use this bug only for the colors not the radius. The round / square tabs is very controversial and should be treaded indepenently. Pierre-Yves, can you update your patch to only change the colors?
Or make it a new theme, or change the default and preserve the old bluish round style as extra theme. As far as I remember there where plans to remove the platform dependent theme entries so one theme more or less wouldn't hurt. Tab corners are indeed controversial but then again Win10 became a lot more square compared to Win7 and Pierre met the Win10 esthetic very good in my opinion. But overall I don't care as long as you don't break my classic theme.
(In reply to Lars Vogel from comment #18) > I suggest to use this bug only for the colors not the radius. The round / > square tabs is very controversial and should be treaded indepenently. We really need a clear objective IMHO. What are the default themes for each platform trying to achieve? * if the objective is to align Eclipse's default theme with native styling on Windows, then there is no controversy, square vs. round is not a decision to be made by Eclipse. As Paul mentioned, Win10 became a lot more square compared to Win7, therefore if people are unhappy with square tabs, they should complain to Microsoft's UI team, or stick with an older version of Eclipse which they run on Win7. Using round tabs would be overriding platform default styling, going against the objective. * if the objective is to allow for creativity and deviation from native styling, then square vs. round is open to debate. But in this case, this very bug would be open to debate as well, maybe some users prefer the blueish colours after all! :) (In reply to Paul Pazderski from comment #19) > But overall I don't care as long as you don't break my classic theme. Is that "Classic" or "Windows Classic"? Not sure what the difference is between the two. Preserving the old bluish round style as extra theme could indeed work, provided we remove all the platform-specific entries from the list. Some sort of "Light Windows 7 Era" theme. :)
(In reply to Pierre-Yves B. from comment #20) > (In reply to Paul Pazderski from comment #19) > > But overall I don't care as long as you don't break my classic theme. > > Is that "Classic" or "Windows Classic"? Not sure what the difference is > between the two. "Windows Classic" recently. But I have seen I used "Classic" in another workspace and couldn't tell you a difference.
(In reply to Paul Pazderski from comment #21) > "Windows Classic" recently. But I have seen I used "Classic" in another > workspace and couldn't tell you a difference. looking at the source code, they're exactly the same. I've raised Bug 562794 to delete one of them.
Created attachment 282695 [details] Tab color only This is what the patch would be with round tabs.
(In reply to Paul Pazderski from comment #19) > Or make it a new theme, or change the default and preserve the old bluish > round style as extra theme. > As far as I remember there where plans to remove the platform dependent > theme entries Bug 562227 > so one theme more or less wouldn't hurt. I think this is there we will end up, I plan to update the default theme and afterwards offer it in two variants, one with square and one with round tabs.
(In reply to Lars Vogel from comment #24) > (In reply to Paul Pazderski from comment #19) > I think this is there we will end up, I plan to update the default theme and > afterwards offer it in two variants, one with square and one with round tabs. The PMC decided that we should not offer more theme but offer a a preference. Once we have a preference the PMC decided to enable square tabs by default. As for this bug, I plan to rebase the changes and release them soon as this sinks our theming with win 10.
New Gerrit change created: https://git.eclipse.org/r/162654
Gerrit change https://git.eclipse.org/r/161669 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c1536a6ac3def57bddb6bcffda5da3a14687c15c
Gerrit change https://git.eclipse.org/r/162654 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=a60e00e189d730b7ddcab5f07bce5857fb575653
Gerrit change https://git.eclipse.org/r/161939 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9df6672c722ad70a2707bd2f719f048db6b21bab
Thanks, Pierre-Yves. I'm sure some people will miss the old blue styled theme but my understanding is that the PMC is in favour of alignment with the win10 theme.
(In reply to Lars Vogel from comment #30) > Thanks, Pierre-Yves. > > I'm sure some people will miss the old blue styled theme but my > understanding is that the PMC is in favour of alignment with the win10 theme. Thanks for reviewing Lars! I've got a feeling I may need to tweak one or two colours once Bug 562232 gets landed, will open a refinement bug and patch then.
Created attachment 282787 [details] inactive.png Hi, Does colors of org-eclipse-ui-workbench-INACTIVE_UNSELECTED_TABS_COLOR_START and org-eclipse-ui-workbench-INACTIVE_UNSELECTED_TABS_COLOR_END and shall be equals to Active ones ? It seems not natural on Win10 to see so much changes on Active Tab change (see inactive.png) Thanks Regards
(In reply to Philippe Dul from comment #32) > Created attachment 282787 [details] > inactive.png > > Hi, > > Does colors of org-eclipse-ui-workbench-INACTIVE_UNSELECTED_TABS_COLOR_START > and org-eclipse-ui-workbench-INACTIVE_UNSELECTED_TABS_COLOR_END and shall be > equals to Active ones ? > > It seems not natural on Win10 to see so much changes on Active Tab change > (see inactive.png) > > Thanks > Regards Hi Philippe, thanks for the feedback. I used different colours to make the difference between the active and inactive parts more obvious, but can change things if you feel strongly about them :)
Created attachment 282788 [details] firefox.png Hi, Yes, INACTIVE_UNSELECTED_TABS_COLORS are the colors the most displayed on the window For instance, in Firefox, this 'dark gray' is used on hover, but inactive tab have same colors than toolbar. (see firefox.png) With bugzilla #497586 and active tab being white, i think these additional colors INACTIVE_UNSELECTED_TABS_COLORS shall be aligned. What do you think of this? Thanks
(In reply to Philippe Dul from comment #34) > Created attachment 282788 [details] > firefox.png > > Hi, > > Yes, INACTIVE_UNSELECTED_TABS_COLORS are the colors the most displayed on > the window > > For instance, in Firefox, this 'dark gray' is used on hover, but inactive > tab have same colors than toolbar. (see firefox.png) > > With bugzilla #497586 and active tab being white, i think these additional > colors INACTIVE_UNSELECTED_TABS_COLORS shall be aligned. > > What do you think of this? > > Thanks Please provide Gerrit so that we can test
New Gerrit change created: https://git.eclipse.org/r/162858
Gerrit change https://git.eclipse.org/r/162858 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3f9a08a7e936e701704c044ca6adef9797a5420c
I presume this did not change the tab style to rectangle, right? Something also changed with the non-active view and editor area background: it's now grey instead of white. I don't think it's from this change, but are you aware of this?
(In reply to Dani Megert from comment #38) > I presume this did not change the tab style to rectangle, right? No, it didn't. > Something also changed with the non-active view and editor area background: > it's now grey instead of white. I don't think it's from this change, but are > you aware of this? I think it's from the latest patch made under this patch: (In reply to Eclipse Genie from comment #36) > New Gerrit change created: https://git.eclipse.org/r/162858 See comments 32, 33 and 34 explaining why this was done.
Square tabs was done via https://bugs.eclipse.org/bugs/show_bug.cgi?id=562221
I don't know if it was this bug that introduced the changes that I'm complaining about in https://bugs.eclipse.org/bugs/show_bug.cgi?id=564884 but I find it's way too hard to understand/see which tab is active. It's fine to look at how firefox renders things, but firefox doesn't change the visual indicator of the active tab when the window looses focus the same way that Eclipse removes that indicator when the editor area or view area isn't active. I should be able to see quickly at a glance which tab's contents are being displayed, not hunt for some slight missing gray on gram...
