562232 – Square tabs are missing outlines for selectedTab

Bug 562232 - Square tabs are missing outlines for selectedTab

Summary: Square tabs are missing outlines for selectedTab

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.16
Hardware:	PC Windows 10

Importance:	P3 normal (vote)
Target Milestone:	4.16 M3
Assignee:	Mike Marchand
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2020-04-16 14:29 EDT by Mike Marchand
Modified:	2020-05-27 17:21 EDT (History)
CC List:	4 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Dark - Square Tabs with Outline - After (7.80 KB, image/png) 2020-04-16 20:50 EDT, Mike Marchand	no flags	Details
Light - Square Tabs with Outline - After (7.45 KB, image/png) 2020-04-16 20:51 EDT, Mike Marchand	no flags	Details
Dark - Bottom tab - After (74.15 KB, image/png) 2020-04-16 20:52 EDT, Mike Marchand	no flags	Details
Dark - Square Tabs with Outline - Before (7.78 KB, image/png) 2020-04-16 21:02 EDT, Mike Marchand	no flags	Details
Light - Square Tabs with Outline - Before (7.43 KB, image/png) 2020-04-16 21:03 EDT, Mike Marchand	no flags	Details
Dark - Bottom tab - Before (58.08 KB, image/png) 2020-04-16 21:04 EDT, Mike Marchand	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mike Marchand

2020-04-16 14:29:44 EDT

I just noticed that the new square tabs are missing outlines.  This isn't as noticeable for regular tabs, but it's extra noticeable for SWT.BOTTOM CTabFolders such as those plugin.xml editor.

The reason it's more noticeable for SWT.BOTTOM is that selected tabs are not being drawn with the selected tab fill color (swt-selected-tab-fill).  I will open another bug for that.

Comment 1 Eclipse Genie

2020-04-16 14:35:23 EDT

New Gerrit change created: https://git.eclipse.org/r/161097

Comment 2 Andrew Obuchowicz

2020-04-16 20:42:16 EDT

Good catch Mike!

Would you be able to submit a screenshot of before/after the fix is applied? (If you have the time of course).

Also, thank you so much for your improvements & involvement with CTabFolder. I look forward to using them in my own theme :)

Comment 3 Mike Marchand

2020-04-16 20:50:37 EDT

Created attachment 282491 [details]
Dark - Square Tabs with Outline - After

Comment 4 Mike Marchand

2020-04-16 20:51:00 EDT

Created attachment 282492 [details]
Light - Square Tabs with Outline - After

Comment 5 Mike Marchand

2020-04-16 20:52:37 EDT

Created attachment 282493 [details]
Dark - Bottom tab - After

 (artificially forced all CTabs to bottom)

Comment 6 Mike Marchand

2020-04-16 21:02:33 EDT

Created attachment 282494 [details]
Dark - Square Tabs with Outline - Before

Comment 7 Mike Marchand

2020-04-16 21:03:01 EDT

Created attachment 282495 [details]
Light - Square Tabs with Outline - Before

Comment 8 Mike Marchand

2020-04-16 21:04:15 EDT

Created attachment 282496 [details]
Dark - Bottom tab - Before

Comment 9 Lars Vogel

2020-04-17 06:51:41 EDT

Mike, can you assign the bug to you and set the target milestone?

Comment 10 Eclipse Genie

2020-05-07 13:21:03 EDT

Gerrit change https://git.eclipse.org/r/161097 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4a03c6da4304b480183bd7213ef15112eae273db

Comment 11 Lars Vogel

2020-05-07 13:34:18 EDT

Thanks, Mike.