Bug 550662 - Cache ViewCSSImpl#getComputedStyle
Summary: Cache ViewCSSImpl#getComputedStyle
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.13   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on: 550651
Blocks:
  Show dependency tree
 
Reported: 2019-09-02 10:00 EDT by Lars Vogel CLA
Modified: 2020-05-19 09:44 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2019-09-02 10:00:47 EDT 
During startup ViewCSSImpl#getComputedStyle is called 1236 in the SDK.

We should add some caching similar to Bug 532869.
Comment 1 Lars Vogel CLA 2019-09-02 10:02:16 EDT 
1236 times.
Comment 2 Lars Vogel CLA 2019-09-02 10:11:21 EDT 
From the first iteration (not tested in detail)

org.eclipse.e4.ui.css.core.impl.dom.ViewCSSImpl.getComputedStyle(Element, String) ViewCSSImpl.java 

Old logic:

Total time 5841ms 

With caching:
Total time 3572ms
Comment 3 Eclipse Genie CLA 2019-09-02 10:20:56 EDT 
New Gerrit change created: https://git.eclipse.org/r/148725
Comment 4 Eclipse Genie CLA 2019-09-02 10:20:58 EDT 
New Gerrit change created: https://git.eclipse.org/r/148724
Comment 5 Dani Megert CLA 2019-10-10 09:37:37 EDT 
Removed milestone as no one reacted to https://www.eclipse.org/lists/eclipse-dev/msg11217.html.
Comment 6 Lars Vogel CLA 2020-05-19 09:44:13 EDT 
I have no plans to work on this, please reopen if someone wants to work on this.