532869 – [ViewCSSImpl] Cache combined CSS rules

Bug 532869 - [ViewCSSImpl] Cache combined CSS rules

Summary: [ViewCSSImpl] Cache combined CSS rules

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.8
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	4.8 M7
Assignee:	Karsten Thoms
QA Contact:

URL:
Whiteboard:
Keywords:	performance

Depends on:
Blocks:

Reported:	2018-03-25 15:21 EDT by Karsten Thoms
Modified:	2018-04-18 02:15 EDT (History)
CC List:	1 user (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Karsten Thoms

2018-03-25 15:21:02 EDT

ViewCSSImpl#getComputedStyle rebuilds the list combinedRuleList with each call. In my case there are 6 stylesheets and overall 175 rules that are collected by the method with each call, and the method is called some thousand times.

When the DocumentCSS contains the same stylesheets as in the last call, the list of combined rules are equal, making it a caching candidate.

Comment 1 Eclipse Genie

2018-03-25 15:30:40 EDT

New Gerrit change created: https://git.eclipse.org/r/120152

Comment 2 Eclipse Genie

2018-04-18 02:14:32 EDT

Gerrit change https://git.eclipse.org/r/120152 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0594e855c4da302b50c9d04b76b9b6aba5c2f5ad

Comment 3 Alexander Kurtakov

2018-04-18 02:15:11 EDT

In master now. Thanks Karsten.