Bug 550261 - "Searching..." does not stop in Quick Search dialog
Summary: "Searching..." does not stop in Quick Search dialog
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.13   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.13 RC1   Edit
Assignee: Paul Pazderski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 548518
  Show dependency tree
 
Reported: 2019-08-20 05:55 EDT by Sarika Sinha CLA
Modified: 2019-08-26 23:53 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sarika Sinha CLA 2019-08-20 05:55:32 EDT 
After searching a word in quick search dialog, the result come and I see the list complete but still "Searching..." stays for ever.

I have JDT Core and JDT debug files from the repository. (Medium sized workspace).


With a single file in the workspace, I do not see any "Searching..." as it gets completed very fast.
Comment 1 Paul Pazderski CLA 2019-08-20 06:21:13 EDT 
I'm quite sure the error comes from the maxResults. If you search for something which match less than (I think) 200 times the "Searching..." is removed.

Some minor bug with incremental update and ResourceWalkter.suspend()
Comment 2 Sarika Sinha CLA 2019-08-20 07:50:03 EDT 
(In reply to Paul Pazderski from comment #1)
> I'm quite sure the error comes from the maxResults. If you search for
> something which match less than (I think) 200 times the "Searching..." is
> removed.
> 
> Some minor bug with incremental update and ResourceWalkter.suspend()

Yes, if result is very less "Searching..." is removed.
Comment 3 Kris De Volder CLA 2019-08-20 11:28:12 EDT 
This was by design really. The search is not 'complete' so the 'Searching...' is shown as a indication of that. Initially I also had the intention of having this search automatically resume if user scrolls down in the view to reveal more elements as they reach the end. I couldn't get this to work properly because adding elements would tend to mess up / reset the views scroll position.

Anyhow, we should probably just disable the progress 'Searching...' indicator when a search with many results hits the maximum.
Comment 4 Eclipse Genie CLA 2019-08-21 04:44:05 EDT 
New Gerrit change created: https://git.eclipse.org/r/148027
Comment 5 Paul Pazderski CLA 2019-08-21 12:57:01 EDT 
I'll merge it for 4.14M1. If someone want it earlier handle the merge yourself.
Comment 6 Lars Vogel CLA 2019-08-21 13:40:58 EDT 
+1 from merge for RC1 from project lead, if you want Paul.
Comment 8 Sarika Sinha CLA 2019-08-26 23:53:04 EDT 
Eclipse SDK

Version: 2019-09 (4.13)
Build id: I20190826-1800